2006-08-10 20:21:21

by Andi Kleen

Subject: [PATCH for review] [31/145] x86_64: Don't print virtual address in HPET initialization

r

virtual addresses don't belong into kernel logs for non debugging

Cc: [email protected]
Signed-off-by: Andi Kleen <[email protected]>

---
drivers/char/hpet.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/char/hpet.c
===================================================================
--- linux.orig/drivers/char/hpet.c
+++ linux/drivers/char/hpet.c
@@ -868,8 +868,8 @@ int hpet_alloc(struct hpet_data *hdp)
do_div(temp, period);
hpetp->hp_tick_freq = temp; /* ticks per second */

- printk(KERN_INFO "hpet%d: at MMIO 0x%lx (virtual 0x%p), IRQ%s",
- hpetp->hp_which, hdp->hd_phys_address, hdp->hd_address,
+ printk(KERN_INFO "hpet%d: at MMIO 0x%lx, IRQ%s",
+ hpetp->hp_which, hdp->hd_phys_address,
hpetp->hp_ntimer > 1 ? "s" : "");
for (i = 0; i < hpetp->hp_ntimer; i++)
printk("%s %d", i > 0 ? "," : "", hdp->hd_irq[i]);

2006-08-11 16:50:27

by Clemens Ladisch

Subject: Re: [PATCH for review] [31/145] x86_64: Don't print virtual address in HPET initialization

Andi Kleen wrote:
> virtual addresses don't belong into kernel logs for non debugging
> ...
> +++ linux/drivers/char/hpet.c

Very minor nitpick: this file is used on i386, too.


Clemens