Thanks to Stephen Smalley for pointing out that we need to securely
handle a failure to register with the LSM security hooks. This patch
adds a panic in the event that the module is unable to register.
Signed-off-by: Kylene Hall <[email protected]>
Signed-off-by: Mimi Zohar <[email protected]>
---
security/slim/slm_main.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.18-rc6-orig/security/slim/slm_main.c 2006-09-18 16:41:51.000000000 -0500
+++ linux-2.6.18-rc6/security/slim/slm_main.c 2006-09-19 12:48:42.000000000 -0500
@@ -1644,9 +1644,13 @@ int slim_enabled = 1;
#endif
static int __init init_slm(void)
{
+ int rc;
if (!slim_enabled)
return 0;
slm_task_init_alloc_security(current);
- return register_security(&slm_security_ops);
+ rc = register_security(&slm_security_ops);
+ if (rc != 0)
+ panic("SLIM: Unable to register with kernel\n");
+ return rc;
}
security_initcall(init_slm);