2006-09-24 22:56:57

by Eric Sesterhenn

[permalink] [raw]
Subject: [Patch] Remove unnecessary check in drivers/pci/hotplug/pciehp_ctrl.c

hi,

this was spotted by coverity (cid #819). We dereference p_slot
earlier in the function, and i found no way it could become NULL
anywhere.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.18-git3/drivers/pci/hotplug/pciehp_ctrl.c.orig 2006-09-24 22:19:11.000000000 +0200
+++ linux-2.6.18-git3/drivers/pci/hotplug/pciehp_ctrl.c 2006-09-24 22:25:10.000000000 +0200
@@ -790,8 +790,7 @@ int pciehp_enable_slot(struct slot *p_sl
p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
}

- if (p_slot)
- update_slot_info(p_slot);
+ update_slot_info(p_slot);

return rc;
}