2006-09-24 20:52:17

by David Woodhouse

[permalink] [raw]
Subject: Re: [S390] remove old z90crypt driver.

On Fri, 2006-09-22 at 21:01 +0000, Linux Kernel Mailing List wrote:
> [S390] remove old z90crypt driver.
>
> The z90crypt driver has served its term. It is replaced by the shiny
> new zcrypt device driver.
>
> Signed-off-by: Martin Schwidefsky <[email protected]>

You neglected to remove the defunct z90crypt.h from
include/asm-s390/Kbuild, breaking 'make headers_install' on s390.

You also neglected to export the new asm/zcrypt.h too. This should fix
both:

Signed-off-by: David Woodhouse <[email protected]>

--- a/include/asm-s390/Kbuild
+++ b/include/asm-s390/Kbuild
@@ -6,7 +6,7 @@ header-y += qeth.h
header-y += tape390.h
header-y += ucontext.h
header-y += vtoc.h
-header-y += z90crypt.h
+header-y += zcrypt.h

unifdef-y += cmb.h
unifdef-y += debug.h

--
dwmw2


2006-09-25 08:11:27

by Martin Schwidefsky

[permalink] [raw]
Subject: Re: [S390] remove old z90crypt driver.

On Sun, 2006-09-24 at 21:51 +0100, David Woodhouse wrote:
> You neglected to remove the defunct z90crypt.h from
> include/asm-s390/Kbuild, breaking 'make headers_install' on s390.
>
> You also neglected to export the new asm/zcrypt.h too. This should fix
> both:
>
> Signed-off-by: David Woodhouse <[email protected]>
>
> --- a/include/asm-s390/Kbuild
> +++ b/include/asm-s390/Kbuild
> @@ -6,7 +6,7 @@ header-y += qeth.h
> header-y += tape390.h
> header-y += ucontext.h
> header-y += vtoc.h
> -header-y += z90crypt.h
> +header-y += zcrypt.h
>
> unifdef-y += cmb.h
> unifdef-y += debug.h
>

Unfortunately true. The patches for the new crypto driver originate from
before headers_install. I forgot to update them accordingly ..
Anyway, thanks for the heads up. I'll add the patch to git390.

--
blue skies,
Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


2006-09-25 08:19:09

by David Woodhouse

[permalink] [raw]
Subject: Re: [S390] remove old z90crypt driver.

On Mon, 2006-09-25 at 10:11 +0200, Martin Schwidefsky wrote:
> Unfortunately true. The patches for the new crypto driver originate from
> before headers_install. I forgot to update them accordingly ..
> Anyway, thanks for the heads up. I'll add the patch to git390.

It's in Linus' tree already.

--
dwmw2