2006-09-26 10:51:08

by Eric Sesterhenn

Subject: [Patch] Possible dereference in net/core/rtnetlink.c

hi,

another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.18-git5/net/core/rtnetlink.c.orig 2006-09-26 12:48:03.000000000 +0200
+++ linux-2.6.18-git5/net/core/rtnetlink.c 2006-09-26 12:48:28.000000000 +0200
@@ -562,7 +562,7 @@ static int rtnl_getlink(struct sk_buff *

err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFLA_MAX, ifla_policy);
if (err < 0)
- goto errout;
+ return err;

ifm = nlmsg_data(nlh);
if (ifm->ifi_index >= 0) {

2006-09-27 06:29:03

by David Miller

Subject: Re: [Patch] Possible dereference in net/core/rtnetlink.c

From: Eric Sesterhenn <[email protected]>
Date: Tue, 26 Sep 2006 12:50:51 +0200

> another possible dereference spotted by coverity (#cid 1390).
> if the nlmsg_parse() call fails, we goto errout, where we call
> dev_put(), with dev still initialized to NULL.
>
> Signed-off-by: Eric Sesterhenn <[email protected]>

Applied, thanks Eric.