2006-10-04 15:48:34

by Eric Sesterhenn

[permalink] [raw]
Subject: [Patch] Use after free in drivers/usb/input/wacom_sys.c

hi,

the following commit added a use after free
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3bea733ab21247290bd552dd6a2cd3049af9adef
Found by coverity (cid #1441)

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.18-git21/drivers/usb/input/wacom_sys.c.orig 2006-10-04 17:42:01.000000000 +0200
+++ linux-2.6.18-git21/drivers/usb/input/wacom_sys.c 2006-10-04 17:42:13.000000000 +0200
@@ -285,8 +285,8 @@ static void wacom_disconnect(struct usb_
input_unregister_device(wacom->dev);
usb_free_urb(wacom->irq);
usb_buffer_free(interface_to_usbdev(intf), 10, wacom->wacom_wac->data, wacom->data_dma);
- kfree(wacom);
kfree(wacom->wacom_wac);
+ kfree(wacom);
}
}