2017-11-17 18:04:30

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error checking.

The platform_get_irq_byname() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq_byname() error
checking for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v1 :
Patch description was not correct.

drivers/phy/motorola/phy-cpcap-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
index accaaac..6601ad0 100644
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -310,7 +310,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
int irq, error;

irq = platform_get_irq_byname(pdev, name);
- if (!irq)
+ if (irq < 0)
return -ENODEV;

error = devm_request_threaded_irq(ddata->dev, irq, NULL,
--
2.7.4


From 1584336515094340855@xxx Fri Nov 17 17:50:42 +0000 2017
X-GM-THRID: 1584268831442657910
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread