2006-10-05 10:56:47

by Eric Sesterhenn

[permalink] [raw]
Subject: [Patch] Dereference in fs/jbd/journal.c

hi,

since the commit http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d1807793e1e7e502e3dc047115e9dbc3b50e4534
we dereference a NULL pointer. Coverity id #1432.
We set journal to NULL, and use it directly afterwards.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.19-rc1/fs/jbd/journal.c.orig 2006-10-05 12:53:24.000000000 +0200
+++ linux-2.6.19-rc1/fs/jbd/journal.c 2006-10-05 12:53:41.000000000 +0200
@@ -724,7 +724,7 @@ journal_t * journal_init_dev(struct bloc
printk(KERN_ERR "%s: Cant allocate bhs for commit thread\n",
__FUNCTION__);
kfree(journal);
- journal = NULL;
+ return NULL;
}
journal->j_dev = bdev;
journal->j_fs_dev = fs_dev;