2006-10-06 04:54:49

by Amol Lad

Subject: [PATCH 3/5] ioremap balanced with iounmap for drivers/char/moxa.c

Signed-off-by: Amol Lad <[email protected]>
---
moxa.c | 6 ++++++
1 files changed, 6 insertions(+)
---
diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/char/moxa.c linux-2.6.19-rc1/drivers/char/moxa.c
--- linux-2.6.19-rc1-orig/drivers/char/moxa.c 2006-10-05 14:00:43.000000000 +0530
+++ linux-2.6.19-rc1/drivers/char/moxa.c 2006-10-05 14:50:00.000000000 +0530
@@ -493,6 +493,12 @@ static void __exit moxa_exit(void)
if (tty_unregister_driver(moxaDriver))
printk("Couldn't unregister MOXA Intellio family serial driver\n");
put_tty_driver(moxaDriver);
+
+ for (i = 0; i < MAX_BOARDS; i++) {
+ if (moxaBaseAddr[i])
+ iounmap(moxaBaseAddr[i]);
+ }
+
if (verbose)
printk("Done\n");
}

2006-10-06 10:53:40

by Alan

Subject: Re: [PATCH 3/5] ioremap balanced with iounmap for drivers/char/moxa.c

Ar Gwe, 2006-10-06 am 10:27 +0530, ysgrifennodd Amol Lad:
> Signed-off-by: Amol Lad <[email protected]>
> ---
> moxa.c | 6 ++++++
> 1 files changed, 6 insertions(+)
> ---


Looks ok to me

Signed-off-by: Alan Cox <[email protected]>