2006-10-22 23:35:44

by Nigel Cunningham

Subject: [PATCH] Quieten Freezer if !CONFIG_PM_DEBUG

The freezer currently prints an '=' for every process that is frozen.
This is pretty pointless, as the equals sign says nothing about which
process is frozen, and makes logs look messier (especially if there were
a large number of processes running). All we really need to know is that
we started trying to freeze processes and what processes (if any) failed
to freeze, or that we succeeded.

Signed-off-by: Nigel Cunningham <[email protected]>

diff --git a/kernel/power/process.c b/kernel/power/process.c
index 29be608..b0edfc6 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -40,7 +40,6 @@ void refrigerator(void)
long save;
save = current->state;
pr_debug("%s entered refrigerator\n", current->comm);
- printk("=");

frozen_process(current);
spin_lock_irq(&current->sighand->siglock);

2006-10-23 15:11:00

by Pavel Machek

Subject: Re: [PATCH] Quieten Freezer if !CONFIG_PM_DEBUG

Hi!

> The freezer currently prints an '=' for every process that is frozen.
> This is pretty pointless, as the equals sign says nothing about which
> process is frozen, and makes logs look messier (especially if there were
> a large number of processes running). All we really need to know is that
> we started trying to freeze processes and what processes (if any) failed
> to freeze, or that we succeeded.

> Signed-off-by: Nigel Cunningham <[email protected]>

ACK.
Pavel


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html