2006-11-13 21:03:38

by Adrian Bunk

Subject: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static

irq_vector[] can now become static.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old 2006-11-13 18:13:14.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c 2006-11-13 18:13:25.000000000 +0100
@@ -1242,7 +1242,7 @@
}

/* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
-u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
+static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };

static int __assign_irq_vector(int irq)
{

2006-11-13 21:33:26

by Eric W. Biederman

Subject: Re: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static

Adrian Bunk <[email protected]> writes:

> irq_vector[] can now become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Eric W. Biederman <[email protected]>

I made this change on x86_64 and forgot it can equally apply to i386.

> --- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old 2006-11-13
> 18:13:14.000000000 +0100
> +++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c 2006-11-13
> 18:13:25.000000000 +0100
> @@ -1242,7 +1242,7 @@
> }
>
> /* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
> -u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
> +static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0
> };
>
> static int __assign_irq_vector(int irq)
> {

Eric

2006-11-14 07:01:57

by Ingo Molnar

Subject: Re: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static

On Mon, 2006-11-13 at 22:03 +0100, Adrian Bunk wrote:
> irq_vector[] can now become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ingo Molnar <[email protected]>

Ingo