2022-06-30 14:45:05

by Michael Walle

Subject: [PATCH net-next 4/4] ARM: dts: lan966x: use new microchip,lan9668-switch compatible

The old generic microchip,lan966x-switch compatible string was
deprecated. Use the new one.

Signed-off-by: Michael Walle <[email protected]>
---
arch/arm/boot/dts/lan966x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index 48971d80c82c..da0657c57cdf 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -85,7 +85,7 @@ soc {
ranges;

switch: switch@e0000000 {
- compatible = "microchip,lan966x-switch";
+ compatible = "microchip,lan9668-switch";
reg = <0xe0000000 0x0100000>,
<0xe2000000 0x0800000>;
reg-names = "cpu", "gcb";
--
2.30.2

2022-06-30 19:26:48

by Krzysztof Kozlowski

Subject: Re: [PATCH net-next 4/4] ARM: dts: lan966x: use new microchip,lan9668-switch compatible

On 30/06/2022 16:02, Michael Walle wrote:
> The old generic microchip,lan966x-switch compatible string was
> deprecated. Use the new one.
>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 48971d80c82c..da0657c57cdf 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -85,7 +85,7 @@ soc {
> ranges;
>
> switch: switch@e0000000 {
> - compatible = "microchip,lan966x-switch";
> + compatible = "microchip,lan9668-switch";

While technically correct, the change cannot go via independent trees
and may break out-of-tree users of this DTS.

Usually the nicer way is to use two compatibles (the old as fallback).
Anyway, this one is fine with me - up to subarch maintainer.

Best regards,
Krzysztof