Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/amd/acp-pcm-dma.c: In function 'acp_dma_open':
sound/soc/amd/acp-pcm-dma.c:714:35: error: 'struct dw_i2s_dev' has no member named 'i2s_instance'; did you mean 'i2s_base'?
adata->i2s_play_instance = dev->i2s_instance;
^~~~~~~~~~~~
i2s_base
sound/soc/amd/acp-pcm-dma.c:715:35: error: 'I2S_SP_INSTANCE' undeclared (first use in this function); did you mean 'SS_ONSTACK'?
if (adata->i2s_play_instance == I2S_SP_INSTANCE)
^~~~~~~~~~~~~~~
SS_ONSTACK
sound/soc/amd/acp-pcm-dma.c:715:35: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/amd/acp-pcm-dma.c:717:40: error: 'I2S_BT_INSTANCE' undeclared (first use in this function); did you mean 'I2S_SP_INSTANCE'?
else if (adata->i2s_play_instance == I2S_BT_INSTANCE)
^~~~~~~~~~~~~~~
I2S_SP_INSTANCE
sound/soc/amd/acp-pcm-dma.c:722:38: error: 'struct dw_i2s_dev' has no member named 'i2s_instance'; did you mean 'i2s_base'?
adata->i2s_capture_instance = dev->i2s_instance;
^~~~~~~~~~~~
i2s_base
sound/soc/amd/acp-pcm-dma.c: In function 'acp_dma_close':
sound/soc/amd/acp-pcm-dma.c:1046:8: error: 'I2S_BT_INSTANCE' undeclared (first use in this function)
case I2S_BT_INSTANCE:
^~~~~~~~~~~~~~~
sound/soc/amd/acp-pcm-dma.c:1049:8: error: 'I2S_SP_INSTANCE' undeclared (first use in this function); did you mean 'I2S_BT_INSTANCE'?
case I2S_SP_INSTANCE:
^~~~~~~~~~~~~~~
I2S_BT_INSTANCE
Caused by commit
363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
I have used the sound-asoc tree from next-20180320 for today.
--
Cheers,
Stephen Rothwell
On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
> Caused by commit
> 363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
> I have used the sound-asoc tree from next-20180320 for today.
Dropped.
On Wednesday 21 March 2018 08:15 AM, Mark Brown wrote:
> On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
>
>> Caused by commit
>> 363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
>> I have used the sound-asoc tree from next-20180320 for today.
> Dropped.
There is a patch dependency .
Below patch not merged yet. We submitted for upstream review.
[PATCH V2] ASoC: dwc: I2S Controller instance param added
On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote:
> There is a patch dependency .
> Below patch not merged yet. We submitted for upstream review.
> [PATCH V2] ASoC: dwc: I2S Controller instance param added
You need to mention dependencies between patches when publishing and I
don't seem to have a copy of that patch, according to the list archives
Alex asked you to make some chnages to it.
On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
> On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote:
>
>> There is a patch dependency .
>> Below patch not merged yet. We submitted for upstream review.
>> [PATCH V2] ASoC: dwc: I2S Controller instance param added
> You need to mention dependencies between patches when publishing and I
> don't seem to have a copy of that patch, according to the list archives
> Alex asked you to make some chnages to it.
?? Changes suggested by Alex already implemented and posted .
?? Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
?? dependent on below patch.
?? https://patchwork.kernel.org/patch/10296597/
?? We will publish patch dependencies while sending patches.
On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote:
> On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
> > You need to mention dependencies between patches when publishing and I
> > don't seem to have a copy of that patch, according to the list archives
> > Alex asked you to make some chnages to it.
> ?? Changes suggested by Alex already implemented and posted .
> ?? Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
> ?? dependent on below patch.
> ?? https://patchwork.kernel.org/patch/10296597/
I'm working offline so these links aren't doing anything useful for me,
sorry.
> ?? We will publish patch dependencies while sending patches.
Please.
On Tuesday 27 March 2018 04:57 PM, Mark Brown wrote:
> On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote:
>> On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
>
>>> You need to mention dependencies between patches when publishing and I
>>> don't seem to have a copy of that patch, according to the list archives
>>> Alex asked you to make some chnages to it.
>
>> ?? Changes suggested by Alex already implemented and posted .
>> ?? Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
>> ?? dependent on below patch.
>
>> ?? https://patchwork.kernel.org/patch/10296597/
>
> I'm working offline so these links aren't doing anything useful for me,
> sorry.
submitted fresh patch set which includes dependent patch.
Please ignore this mail thread.
>
>> ?? We will publish patch dependencies while sending patches.
>
> Please.
>