2007-05-02 17:50:17

by john stultz

[permalink] [raw]
Subject: Re: [PATCH 1/3] ia64: convert to use clocksource code

On Fri, 2007-04-27 at 08:54 -0400, Peter Keilty wrote:
> john stultz wrote:
> >On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote:
> >>From: Peter Keilty <[email protected]>
> >>
> >>Initial ia64 conversion to the generic timekeeping/clocksource code.
> >>
> >>Signed-off-by: Peter Keilty <[email protected]>
> >>Signed-off-by: John Stultz <[email protected]>
> >>
> > Thanks so much for pushing this on! I suspect this patch needs to be
> >updated a touch, as I'm not sure if it still compiles in light of recent
> >changes...
> >
> You are correct, you need patch 3/3 for it to compile and run.
> I did a patch to the orginal patch, thought that was correct thing to do.
> But I can make a new patch 1 from the orginal of ours and my #3.
> I would also make an update to the #2 patch from #3 for ntp correct change.
> That would be just 2 patches then, the enable_ia64 and remove_interpolater.
> What do you think?

Yep. That sounds like the right path to me. Its a good idea to make sure
your patch set compiles each step of the way, so later folks can
properly bisect through it looking for other issues.

thanks
-john