2007-08-01 07:03:23

by Girish Shilamkar

[permalink] [raw]
Subject: Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

On Wed, 2007-07-11 at 17:16 +0530, Girish Shilamkar wrote:

> I will make the changes and send an incremental patch.
>
Hi,
I have made the changes and attached the incremental patch as per the
review.

This is the actual changelog which was missing in the original patch.

------
The journal checksum feature adds two new flags i.e
JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT and JBD2_FEATURE_COMPAT_CHECKSUM.

JBD2_FEATURE_CHECKSUM flag indicates that the commit block contains the
checksum for the blocks described by the descriptor blocks.
Due to checksums, writing of the commit record no longer needs to be
synchronous. Now commit record can be sent to disk without waiting for
descriptor blocks to be written to disk. This behavior is controlled
using JBD2_FEATURE_ASYNC_COMMIT flag. Older kernels/e2fsck should not be
able to recover the journal with _ASYNC_COMMIT hence it is made
incompat.
The commit header has been extended to hold the checksum along with the
type of the checksum.

For recovery in pass scan checksums are verified to ensure the sanity
and completeness(in case of _ASYNC_COMMIT) of every transaction.
-----

Thanks & Regards,
Girish.


Attachments:
jrnl-chksum-fix-review.patch (7.06 kB)

2007-08-07 05:25:30

by Mingming Cao

[permalink] [raw]
Subject: Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

On Wed, 2007-08-01 at 12:34 +0530, Girish Shilamkar wrote:
> On Wed, 2007-07-11 at 17:16 +0530, Girish Shilamkar wrote:
>
> > I will make the changes and send an incremental patch.
> >
> Hi,
> I have made the changes and attached the incremental patch as per the
> review.

Thanks,

I merged your changes to ext4-patch-queue.

Mingming