Dear all,
Would it be possible to include the patches (available on http://www.synce.org)
for WindowsMobile5, as most mobile phones are under Window$, and it is
very convenient to connect it to the laptop under Linux
http://www.synce.org/index.php/Connecting_your_Windows_Mobile_2005_device_via_USB_%28usb-rndis-lite%29
Thanks a lot in advance,
Jom
On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
[...]
> Would it be possible to include the patches (available on http://www.synce.org)
> for WindowsMobile5, as most mobile phones are under Window$, and it is
> very convenient to connect it to the laptop under Linux
do {
Test them
review them
sent them as patches hereover
handle feedback
until(accepted)
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
Hi,
On 10/9/07, Grosjo.net - jom <[email protected]> wrote:
> Would it be possible to include the patches (available on http://www.synce.org)
> for WindowsMobile5, as most mobile phones are under Window$, and it is
> very convenient to connect it to the laptop under Linux
Sounds useful so please ask the synce developers to submit those
patches upstream.
Pekka
On Tue, 2007-10-09 at 11:32 +0200, Bernd Petrovitsch wrote:
> On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
> [...]
> > Would it be possible to include the patches (available on http://www.synce.org)
> > for WindowsMobile5, as most mobile phones are under Window$, and it is
> > very convenient to connect it to the laptop under Linux
>
> do {
> Test them
> review them
> sent them as patches hereover
> handle feedback
> until(accepted)
FWIW, the patch in question is a one-liner:
--- linux-2.6.22-rc3-orig/drivers/net/usb/rndis_host.c 2007-05-25 22:55:14.000000000 -0400
+++ linux-2.6.22-rc3/drivers/net/usb/rndis_host.c 2007-05-27 17:06:16.000000000 -0400
@@ -499,8 +499,7 @@
net->hard_header_len += sizeof (struct rndis_data_hdr);
dev->hard_mtu = net->mtu + net->hard_header_len;
- dev->rx_urb_size = dev->hard_mtu + (dev->maxpacket + 1);
- dev->rx_urb_size &= ~(dev->maxpacket - 1);
+ dev->rx_urb_size = (dev->udev->speed == USB_SPEED_FULL) ? 16384 : 8192;
u.init->max_transfer_size = cpu_to_le32(dev->rx_urb_size);
net->change_mtu = NULL;
Xav
> FWIW, the patch in question is a one-liner:
>
Yes, that is why it shall be probably possible to include it in the kernel ?
I do not have the contact with SynCE developers. Maybe one of you have.
Jom
On Tue, 2007-10-09 at 11:37 +0200, Xavier Bestel wrote:
> FWIW, the patch in question is a one-liner:
That's not a valid argument. This may work with a WM5 device, but looks
very dubious, wrt. other RNDIS devices. Why are these constants
hardcoded and not taken in some way from the descriptors?
There must be some justification why these values need to be hardcoded,
and if so, this must be dependent on the rndis device really being a WM5
device.
Nacked-By: Thomas Sailer <[email protected]>