2007-11-26 10:02:16

by Sonic Zhang

Subject: [PATCH] [libata] Return proper ATA INT status in pata_bf54x driver.

INT status can be OR.


Signed-off-by: Sonic Zhang <[email protected]>

---
drivers/ata/pata_bf54x.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index b5e3842..81db405 100644
--- a/drivers/ata/pata_bf54x.c
+++ b/drivers/ata/pata_bf54x.c
@@ -1145,13 +1145,13 @@ static unsigned char bfin_bmdma_status(s
unsigned short int_status = ATAPI_GET_INT_STATUS(base);

if (ATAPI_GET_STATUS(base) & (MULTI_XFER_ON|ULTRA_XFER_ON)) {
- host_stat = ATA_DMA_ACTIVE;
+ host_stat |= ATA_DMA_ACTIVE;
}
if (int_status & (MULTI_DONE_INT|UDMAIN_DONE_INT|UDMAOUT_DONE_INT)) {
- host_stat = ATA_DMA_INTR;
+ host_stat |= ATA_DMA_INTR;
}
if (int_status & (MULTI_TERM_INT|UDMAIN_TERM_INT|UDMAOUT_TERM_INT)) {
- host_stat = ATA_DMA_ERR;
+ host_stat |= ATA_DMA_ERR;
}

return host_stat;
--
1.4.3.4

2007-11-26 16:04:49

by Jeff Garzik

Subject: Re: [PATCH] [libata] Return proper ATA INT status in pata_bf54x driver.

sonic zhang wrote:
> INT status can be OR.
>
>
> Signed-off-by: Sonic Zhang <[email protected]>
>
> ---
> drivers/ata/pata_bf54x.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

applied