2007-11-29 22:38:45

by Ben Collins

Subject: [SPARC64] Export symbols for sunvnet and sunvdc to be built modular

Fixes this build failure:

ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined!
ERROR: "vio_driver_init" [drivers/block/sunvdc.ko] undefined!
ERROR: "ldc_map_sg" [drivers/block/sunvdc.ko] undefined!

Signed-off-by: Ben Collins <[email protected]>

diff --git a/arch/sparc64/kernel/ldc.c b/arch/sparc64/kernel/ldc.c
index cbe6fa2..be80948 100644
--- a/arch/sparc64/kernel/ldc.c
+++ b/arch/sparc64/kernel/ldc.c
@@ -2105,6 +2105,7 @@ int ldc_map_sg(struct ldc_channel *lp,

return state.nc;
}
+EXPORT_SYMBOL(ldc_map_sg);

int ldc_map_single(struct ldc_channel *lp,
void *buf, unsigned int len,
diff --git a/arch/sparc64/kernel/viohs.c b/arch/sparc64/kernel/viohs.c
index eeeb5ed..708fa17 100644
--- a/arch/sparc64/kernel/viohs.c
+++ b/arch/sparc64/kernel/viohs.c
@@ -819,3 +819,4 @@ int vio_driver_init(struct vio_driver_state *vio, struct vio_dev *vdev,

return 0;
}
+EXPORT_SYMBOL(vio_driver_init);

--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/
SwissDisk: http://www.swissdisk.com/

2007-12-04 08:23:59

by David Miller

Subject: Re: [SPARC64] Export symbols for sunvnet and sunvdc to be built modular

From: Ben Collins <[email protected]>
Date: Thu, 29 Nov 2007 17:02:10 -0500

> Fixes this build failure:
>
> ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined!
> ERROR: "vio_driver_init" [drivers/block/sunvdc.ko] undefined!
> ERROR: "ldc_map_sg" [drivers/block/sunvdc.ko] undefined!
>
> Signed-off-by: Ben Collins <[email protected]>

Please check what you are patching against.

Every 2.6.x tree I have access to has these exports in
the precise locations you are adding them.

I suspect you have some local change intergration issue
in the tree where you encountered this build error.

2007-12-04 13:54:17

by Ben Collins

Subject: Re: [SPARC64] Export symbols for sunvnet and sunvdc to be built modular

On Tue, 2007-12-04 at 00:23 -0800, David Miller wrote:
> From: Ben Collins <[email protected]>
> Date: Thu, 29 Nov 2007 17:02:10 -0500
>
> > Fixes this build failure:
> >
> > ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined!
> > ERROR: "vio_driver_init" [drivers/block/sunvdc.ko] undefined!
> > ERROR: "ldc_map_sg" [drivers/block/sunvdc.ko] undefined!
> >
> > Signed-off-by: Ben Collins <[email protected]>
>
> Please check what you are patching against.
>
> Every 2.6.x tree I have access to has these exports in
> the precise locations you are adding them.
>
> I suspect you have some local change intergration issue
> in the tree where you encountered this build error.

I was pretty sure I diff'd the tree I have against linux-2.6/master, but
maybe not.

Thanks

--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/
SwissDisk: http://www.swissdisk.com/