2007-12-06 15:27:49

by cheng renquan

Subject: [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT

single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.

Signed-off-by: Denis Cheng <[email protected]>
---
fs/afs/cell.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index 970d38f..b4a09ab 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -20,7 +20,7 @@
DECLARE_RWSEM(afs_proc_cells_sem);
LIST_HEAD(afs_proc_cells);

-static struct list_head afs_cells = LIST_HEAD_INIT(afs_cells);
+static LIST_HEAD(afs_cells);
static DEFINE_RWLOCK(afs_cells_lock);
static DECLARE_RWSEM(afs_cells_sem); /* add/remove serialisation */
static DECLARE_WAIT_QUEUE_HEAD(afs_cells_freeable_wq);
--
1.5.3.4

2007-12-06 15:55:44

by David Howells

Subject: Re: [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT

Denis Cheng <[email protected]> wrote:

> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.

And mucks up TAGS generation:-/