2007-12-06 16:08:06

by cheng renquan

Subject: [PATCH 15/20] net/lapb/lapb_iface.c: use LIST_HEAD instead of LIST_HEAD_INIT

single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.

Signed-off-by: Denis Cheng <[email protected]>
---
net/lapb/lapb_iface.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
index a2e7aa6..2ba1bc4 100644
--- a/net/lapb/lapb_iface.c
+++ b/net/lapb/lapb_iface.c
@@ -39,7 +39,7 @@
#include <linux/init.h>
#include <net/lapb.h>

-static struct list_head lapb_list = LIST_HEAD_INIT(lapb_list);
+static LIST_HEAD(lapb_list);
static DEFINE_RWLOCK(lapb_list_lock);

/*
--
1.5.3.4

2007-12-06 16:08:23

by cheng renquan

Subject: [PATCH 16/20] net/x25/: use LIST_HEAD instead of LIST_HEAD_INIT

single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.

Signed-off-by: Denis Cheng <[email protected]>
---
net/x25/x25_forward.c | 2 +-
net/x25/x25_link.c | 2 +-
net/x25/x25_route.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/x25/x25_forward.c b/net/x25/x25_forward.c
index 8738ec7..4dd8ff7 100644
--- a/net/x25/x25_forward.c
+++ b/net/x25/x25_forward.c
@@ -12,7 +12,7 @@
#include <linux/init.h>
#include <net/x25.h>

-struct list_head x25_forward_list = LIST_HEAD_INIT(x25_forward_list);
+LIST_HEAD(x25_forward_list);
DEFINE_RWLOCK(x25_forward_list_lock);

int x25_forward_call(struct x25_address *dest_addr, struct x25_neigh *from,
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index 741ce95..4a3602e 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -30,7 +30,7 @@
#include <linux/init.h>
#include <net/x25.h>

-static struct list_head x25_neigh_list = LIST_HEAD_INIT(x25_neigh_list);
+static LIST_HEAD(x25_neigh_list);
static DEFINE_RWLOCK(x25_neigh_list_lock);

static void x25_t20timer_expiry(unsigned long);
diff --git a/net/x25/x25_route.c b/net/x25/x25_route.c
index 86b5b4d..2c999cc 100644
--- a/net/x25/x25_route.c
+++ b/net/x25/x25_route.c
@@ -21,7 +21,7 @@
#include <linux/init.h>
#include <net/x25.h>

-struct list_head x25_route_list = LIST_HEAD_INIT(x25_route_list);
+LIST_HEAD(x25_route_list);
DEFINE_RWLOCK(x25_route_list_lock);

/*
--
1.5.3.4

2007-12-07 08:50:36

by David Miller

Subject: Re: [PATCH 15/20] net/lapb/lapb_iface.c: use LIST_HEAD instead of LIST_HEAD_INIT

From: Denis Cheng <[email protected]>
Date: Fri, 7 Dec 2007 00:07:18 +0800

> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
>
> Signed-off-by: Denis Cheng <[email protected]>

Applied.

2007-12-07 08:51:22

by David Miller

Subject: Re: [PATCH 16/20] net/x25/: use LIST_HEAD instead of LIST_HEAD_INIT

From: Denis Cheng <[email protected]>
Date: Fri, 7 Dec 2007 00:07:19 +0800

> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
>
> Signed-off-by: Denis Cheng <[email protected]>

Applied.