2007-12-14 10:07:27

by Nicolas Mailhot

[permalink] [raw]
Subject: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter


Le jeudi 13 décembre 2007 à 21:38 -0800, Greg KH a écrit :
> On Thu, Dec 13, 2007 at 11:37:40PM +0100, Nicolas Mailhot wrote:

> > The Gretag-Macbeth Huey display colorimeter claims to be an HID device
> > but isn't. As a result the linux HID device will claim it, preventing
> > FLOSS software like Argyll CMS (http://www.argyllcms.com/) from talking
> > to it,

> > Frédéric Crozat from Mandriva has such a device and may provide more
> > info.

> Care to make up a patch as per the Documentation/SubmittingPatches file
> and send it to this list and the HID driver maintainer? That way you
> get the proper credit for this change.

The things I do as a public service, I don't even have the damn Huey
myself:(

There seems to be some complains about libusb BTW
(http://www.freelists.org/archives/argyllcms/12-2007/msg00068.html)


Signed-off-by: Nicolas Mailhot <[email protected]>

diff -uNr linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c
--- linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c 2007-12-11 04:48:43.000000000 +0100
+++ linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c 2007-12-14 10:41:01.000000000 +0100
@@ -85,6 +85,9 @@
#define USB_VENDOR_ID_CHIC 0x05fe
#define USB_DEVICE_ID_CHIC_GAMEPAD 0x0014

+#define USB_VENDOR_ID_GRETAGMACBETH 0x0971
+#define USB_DEVICE_ID_GRETAGMACBETH_HUEY 0x2005
+
#define USB_VENDOR_ID_CIDC 0x1677

#define USB_VENDOR_ID_CMEDIA 0x0d8c
@@ -423,6 +426,7 @@
{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_SUPER_Q2, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_GOGOPEN, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_PENPOWER, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GRETAGMACBETH, USB_DEVICE_ID_GRETAGMACBETH_HUEY, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_POWERMATE, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_SOUNDKNOB, HID_QUIRK_IGNORE },

--
Nicolas Mailhot


2007-12-14 15:53:43

by Frederic Crozat

[permalink] [raw]
Subject: Re: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter


Le vendredi 14 d?cembre 2007 ? 11:04 +0100, Nicolas Mailhot a ?crit :
> Le jeudi 13 d?cembre 2007 ? 21:38 -0800, Greg KH a ?crit :
> > On Thu, Dec 13, 2007 at 11:37:40PM +0100, Nicolas Mailhot wrote:
>
> > > The Gretag-Macbeth Huey display colorimeter claims to be an HID device
> > > but isn't. As a result the linux HID device will claim it, preventing
> > > FLOSS software like Argyll CMS (http://www.argyllcms.com/) from talking
> > > to it,
>
> > > Fr?d?ric Crozat from Mandriva has such a device and may provide more
> > > info.
>
> > Care to make up a patch as per the Documentation/SubmittingPatches file
> > and send it to this list and the HID driver maintainer? That way you
> > get the proper credit for this change.
>
> The things I do as a public service, I don't even have the damn Huey
> myself:(
>
> There seems to be some complains about libusb BTW
> (http://www.freelists.org/archives/argyllcms/12-2007/msg00068.html)
>
>
> Signed-off-by: Nicolas Mailhot <[email protected]>
>
> diff -uNr linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c
> --- linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c 2007-12-11 04:48:43.000000000 +0100
> +++ linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c 2007-12-14 10:41:01.000000000 +0100
> @@ -85,6 +85,9 @@
> #define USB_VENDOR_ID_CHIC 0x05fe
> #define USB_DEVICE_ID_CHIC_GAMEPAD 0x0014
>
> +#define USB_VENDOR_ID_GRETAGMACBETH 0x0971
> +#define USB_DEVICE_ID_GRETAGMACBETH_HUEY 0x2005
> +
> #define USB_VENDOR_ID_CIDC 0x1677
>
> #define USB_VENDOR_ID_CMEDIA 0x0d8c
> @@ -423,6 +426,7 @@
> { USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_SUPER_Q2, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_GOGOPEN, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_PENPOWER, HID_QUIRK_IGNORE },
> + { USB_VENDOR_ID_GRETAGMACBETH, USB_DEVICE_ID_GRETAGMACBETH_HUEY, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_POWERMATE, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_SOUNDKNOB, HID_QUIRK_IGNORE },

Fixes the issue for me :

Tested-by: Frederic Crozat <[email protected]>

--
Frederic Crozat <[email protected]>
Mandriva