2020-11-05 11:53:02

by Marek Szyprowski

Subject: [PATCH] arm64: dts: exynos: Use fixed index for the MMC devices

Recently introduced asynchronous probe on the MMC devices can shuffle
block IDs in the system. Pin them to values equal to the physical MMC bus
number to ease booting in environments where UUIDs are not practical.

Use newly introduced aliases for mmcblk devices from commit fa2d0aa96941
("mmc: core: Allow setting slot index via device tree alias").

Suggested-by: Markus Reichl <[email protected]>
Signed-off-by: Marek Szyprowski <[email protected]>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++++++
arch/arm64/boot/dts/exynos/exynos7.dtsi | 3 +++
2 files changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 0a886bb6c806..3a37ad97fcdb 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -23,6 +23,12 @@

interrupt-parent = <&gic>;

+ aliases {
+ mmc0 = &mshc_0;
+ mmc1 = &mshc_1;
+ mmc2 = &mshc_2;
+ };
+
arm_a53_pmu {
compatible = "arm,cortex-a53-pmu";
interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 48cd3a04fd07..3e319ec64997 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -16,6 +16,9 @@
#size-cells = <2>;

aliases {
+ mmc0 = &mmc_0;
+ mmc1 = &mmc_1;
+ mmc2 = &mmc_2;
pinctrl0 = &pinctrl_alive;
pinctrl1 = &pinctrl_bus0;
pinctrl2 = &pinctrl_nfc;
--
2.17.1

2020-11-06 06:03:43

by Jaehoon Chung

Subject: Re: [PATCH] arm64: dts: exynos: Use fixed index for the MMC devices

On 11/5/20 8:48 PM, Marek Szyprowski wrote:
> Recently introduced asynchronous probe on the MMC devices can shuffle
> block IDs in the system. Pin them to values equal to the physical MMC bus
> number to ease booting in environments where UUIDs are not practical.
>
> Use newly introduced aliases for mmcblk devices from commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias").
>
> Suggested-by: Markus Reichl <[email protected]>
> Signed-off-by: Marek Szyprowski <[email protected]>


Reviewed-by: Jaehoon Chung <[email protected]>

Best Regards,
Jaehoon Chung

> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++++++
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 3 +++
> 2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 0a886bb6c806..3a37ad97fcdb 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -23,6 +23,12 @@
>
> interrupt-parent = <&gic>;
>
> + aliases {
> + mmc0 = &mshc_0;
> + mmc1 = &mshc_1;
> + mmc2 = &mshc_2;
> + };
> +
> arm_a53_pmu {
> compatible = "arm,cortex-a53-pmu";
> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 48cd3a04fd07..3e319ec64997 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -16,6 +16,9 @@
> #size-cells = <2>;
>
> aliases {
> + mmc0 = &mmc_0;
> + mmc1 = &mmc_1;
> + mmc2 = &mmc_2;
> pinctrl0 = &pinctrl_alive;
> pinctrl1 = &pinctrl_bus0;
> pinctrl2 = &pinctrl_nfc;
>