2024-03-24 09:29:37

by coolrrsh

Subject: [PATCH v1] staging: media: remove duplicates

From: Rajeshwar R Shinde <[email protected]>

In Kconfig, the kernel configuration VIDEO_DEV is defined twice.
To prevent doing repeated checks, the redundant code was replaced.

Signed-off-by: Rajeshwar R Shinde <[email protected]>

---
drivers/staging/media/imx/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index 21fd79515042..772f49b1fe52 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -4,7 +4,6 @@ config VIDEO_IMX_MEDIA
depends on ARCH_MXC || COMPILE_TEST
depends on HAS_DMA
depends on VIDEO_DEV
- depends on VIDEO_DEV
select MEDIA_CONTROLLER
select V4L2_FWNODE
select V4L2_MEM2MEM_DEV
--
2.25.1

2024-03-24 12:06:21

by Philipp Hortmann

Subject: Re: [PATCH v1] staging: media: remove duplicates

On 3/24/24 10:29, [email protected] wrote:
Hi Rajeshwar,

Please make your "Subject" line more unique. Consider that we may end up
with having dozen of commits like yours, all of them referring to
different removals and all without the necessary information to tell
what they differ in (except the driver/subsystem). So it would help if
you add the changed file to make it more unique.

Typically we omit the v1 on the first patch in the subject

> From: Rajeshwar R Shinde <[email protected]>
This line does not belong here. Please remove it.

>
> In Kconfig, the kernel configuration VIDEO_DEV is defined twice.
> To prevent doing repeated checks, the redundant code was replaced.
replaced?

If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp

> Signed-off-by: Rajeshwar R Shinde <[email protected]>
>
> ---
> drivers/staging/media/imx/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 21fd79515042..772f49b1fe52 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -4,7 +4,6 @@ config VIDEO_IMX_MEDIA
> depends on ARCH_MXC || COMPILE_TEST
> depends on HAS_DMA
> depends on VIDEO_DEV
> - depends on VIDEO_DEV
> select MEDIA_CONTROLLER
> select V4L2_FWNODE
> select V4L2_MEM2MEM_DEV