2023-02-09 16:12:10

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779g0 support

Document support for the Thermal Sensor/Chip Internal Voltage
Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4H
(R8A779G0) SoC.

Unlike most other R-Car Gen3 and Gen4 SoCs, it has 4 instead of 3
sensors, so increase the maximum number of reg tuples.
Just like other R-Car Gen4 SoCs, interrupts are not routed to the
INTC-AP but to the ECM.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
.../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
index 0f05f5c886c5fe1d..ecf276fd155cfb27 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
@@ -28,6 +28,7 @@ properties:
- renesas,r8a77980-thermal # R-Car V3H
- renesas,r8a779a0-thermal # R-Car V3U
- renesas,r8a779f0-thermal # R-Car S4-8
+ - renesas,r8a779g0-thermal # R-Car V4H

reg: true

@@ -80,6 +81,7 @@ else:
- description: TSC1 registers
- description: TSC2 registers
- description: TSC3 registers
+ - description: TSC4 registers
if:
not:
properties:
@@ -87,6 +89,7 @@ else:
contains:
enum:
- renesas,r8a779f0-thermal
+ - renesas,r8a779g0-thermal
then:
required:
- interrupts
--
2.34.1



2023-02-09 16:25:25

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779g0 support

On Thu, Feb 09, 2023 at 05:11:53PM +0100, Geert Uytterhoeven wrote:
> Document support for the Thermal Sensor/Chip Internal Voltage
> Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4H
> (R8A779G0) SoC.
>
> Unlike most other R-Car Gen3 and Gen4 SoCs, it has 4 instead of 3
> sensors, so increase the maximum number of reg tuples.

Yep, no docs saying that it belongs to control domain this time (so
far).

> Just like other R-Car Gen4 SoCs, interrupts are not routed to the
> INTC-AP but to the ECM.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (647.00 B)
signature.asc (833.00 B)
Download all attachments

2023-02-09 22:45:12

by Niklas Söderlund

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779g0 support

Hi Geert,

Thanks for your work.

On 2023-02-09 17:11:53 +0100, Geert Uytterhoeven wrote:
> Document support for the Thermal Sensor/Chip Internal Voltage
> Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4H
> (R8A779G0) SoC.
>
> Unlike most other R-Car Gen3 and Gen4 SoCs, it has 4 instead of 3
> sensors, so increase the maximum number of reg tuples.
> Just like other R-Car Gen4 SoCs, interrupts are not routed to the
> INTC-AP but to the ECM.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Niklas S?derlund <[email protected]>

> ---
> .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 0f05f5c886c5fe1d..ecf276fd155cfb27 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -28,6 +28,7 @@ properties:
> - renesas,r8a77980-thermal # R-Car V3H
> - renesas,r8a779a0-thermal # R-Car V3U
> - renesas,r8a779f0-thermal # R-Car S4-8
> + - renesas,r8a779g0-thermal # R-Car V4H
>
> reg: true
>
> @@ -80,6 +81,7 @@ else:
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> + - description: TSC4 registers
> if:
> not:
> properties:
> @@ -87,6 +89,7 @@ else:
> contains:
> enum:
> - renesas,r8a779f0-thermal
> + - renesas,r8a779g0-thermal
> then:
> required:
> - interrupts
> --
> 2.34.1
>

--
Kind Regards,
Niklas S?derlund

2023-02-13 09:11:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779g0 support

On 09/02/2023 17:11, Geert Uytterhoeven wrote:
> Document support for the Thermal Sensor/Chip Internal Voltage
> Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4H
> (R8A779G0) SoC.
>
> Unlike most other R-Car Gen3 and Gen4 SoCs, it has 4 instead of 3
> sensors, so increase the maximum number of reg tuples.
> Just like other R-Car Gen4 SoCs, interrupts are not routed to the
> INTC-AP but to the ECM.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof