net->ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem
has been introduced by the following commit.
commit c8050bf6d84785a7edd2e81591e8f833231477e8
Author: Denis V. Lunev <[email protected]>
Date: Thu Jan 10 03:28:24 2008 -0800
Signed-off-by: Denis V. Lunev <[email protected]>
---
net/ipv4/fib_frontend.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index d282618..d0507f4 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -975,6 +975,7 @@ static struct notifier_block fib_netdev_notifier = {
static int __net_init ip_fib_net_init(struct net *net)
{
+ int err;
unsigned int i;
net->ipv4.fib_table_hash = kzalloc(
@@ -985,7 +986,14 @@ static int __net_init ip_fib_net_init(struct net *net)
for (i = 0; i < FIB_TABLE_HASHSZ; i++)
INIT_HLIST_HEAD(&net->ipv4.fib_table_hash[i]);
- return fib4_rules_init(net);
+ err = fib4_rules_init(net);
+ if (err < 0)
+ goto fail;
+ return 0;
+
+fail:
+ kfree(net->ipv4.fib_table_hash);
+ return err;
}
static void __net_exit ip_fib_net_exit(struct net *net)
--
1.5.3.rc5
From: "Denis V. Lunev" <[email protected]>
Date: Thu, 31 Jan 2008 15:00:45 +0300
> commit c8050bf6d84785a7edd2e81591e8f833231477e8
> Author: Denis V. Lunev <[email protected]>
> Date: Thu Jan 10 03:28:24 2008 -0800
I am fixing it up for you this time, but please do not
reference the commit this way.
Say something like:
blah blah blah in commit $(SHA1_HASH) ("commit head line").
The author and date give no real useful information in
this context, the important part is giving the reader
enough information to find the commit should they wish
to gain more information.
If they have the commit hash they can usually find the
commit, but if that fails they can search the commit
messages for the head line text string.
I feel like I've had to explain this 10 times in the past week...
:-/