2008-02-11 09:49:30

by Jan-Bernd Themann

Subject: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <[email protected]>

---
Hi Greg,

are you the right person to address this patch to?

Regards,
Jan-Bernd

drivers/base/memory.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..1e1bd4c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
{
return blocking_notifier_chain_register(&memory_chain, nb);
}
+EXPORT_SYMBOL(register_memory_notifier);

void unregister_memory_notifier(struct notifier_block *nb)
{
blocking_notifier_chain_unregister(&memory_chain, nb);
}
+EXPORT_SYMBOL(unregister_memory_notifier);

/*
* register_memory - Setup a sysfs device for a memory block
--
1.5.2

2008-02-11 10:12:48

by Dave Hansen

Subject: Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> are you the right person to address this patch to?

You might want to check the top of the file. ;)

> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
> {
> return blocking_notifier_chain_register(&memory_chain, nb);
> }
> +EXPORT_SYMBOL(register_memory_notifier);
>
> void unregister_memory_notifier(struct notifier_block *nb)
> {
> blocking_notifier_chain_unregister(&memory_chain, nb);
> }
> +EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

-- Dave

2008-02-11 10:48:12

by Jan-Bernd Themann

Subject: Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

On Monday 11 February 2008 11:12, Dave Hansen wrote:
> On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> > are you the right person to address this patch to?
>
> You might want to check the top of the file. ;)
>
> > --- a/drivers/base/memory.c
> > +++ b/drivers/base/memory.c
> > @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
> > {
> > return blocking_notifier_chain_register(&memory_chain, nb);
> > }
> > +EXPORT_SYMBOL(register_memory_notifier);
> >
> > void unregister_memory_notifier(struct notifier_block *nb)
> > {
> > blocking_notifier_chain_unregister(&memory_chain, nb);
> > }
> > +EXPORT_SYMBOL(unregister_memory_notifier);
>
> Is there a particular reason these can't be GPL?
>

I don't object to make them GPL. Greg, what do you think?

Regards,
Jan-Bernd

2008-02-11 15:34:38

by Greg KH

Subject: Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

On Mon, Feb 11, 2008 at 11:47:50AM +0100, Jan-Bernd Themann wrote:
> On Monday 11 February 2008 11:12, Dave Hansen wrote:
> > On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> > > are you the right person to address this patch to?
> >
> > You might want to check the top of the file. ;)
> >
> > > --- a/drivers/base/memory.c
> > > +++ b/drivers/base/memory.c
> > > @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
> > > {
> > > return blocking_notifier_chain_register(&memory_chain, nb);
> > > }
> > > +EXPORT_SYMBOL(register_memory_notifier);
> > >
> > > void unregister_memory_notifier(struct notifier_block *nb)
> > > {
> > > blocking_notifier_chain_unregister(&memory_chain, nb);
> > > }
> > > +EXPORT_SYMBOL(unregister_memory_notifier);
> >
> > Is there a particular reason these can't be GPL?
> >
>
> I don't object to make them GPL. Greg, what do you think?

They should be _GPL to match the rest of the driver core.

Care to resend this?

thanks,

greg k-h