2008-02-16 18:38:32

by Adrian McMenamin

[permalink] [raw]
Subject: Current git very broken on the Dreamcast

Will seek to bisect this, but I have just updated my sources to the
latest git and it is not booting at all on the Dreamcast.

With early printk on, I get nothing more than this before an instant
reboot:

[ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd
(adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43
GMT 2008
[ 0.000000] console [sercon0] enabled
[ 0.000000] Booting machvec: Sega Dreamcast


2008-02-16 19:48:52

by Adrian McMenamin

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast


On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> Will seek to bisect this, but I have just updated my sources to the
> latest git and it is not booting at all on the Dreamcast.
>
> With early printk on, I get nothing more than this before an instant
> reboot:
>
> [ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd
> (adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43
> GMT 2008
> [ 0.000000] console [sercon0] enabled
> [ 0.000000] Booting machvec: Sega Dreamcast


adrian@bossclass:~/gdrom-dev$ git bisect good
e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
commit e036eaa681a17f71b64f6d9040fe605555623919
Author: Magnus Damm <[email protected]>
Date: Thu Feb 14 13:52:43 2008 +0900

sh: use ctrl_in/out for on chip pci access

This patch makes sure ctrl_inN/outN are used instead of inN/outN for
on chip
pci registers. Without this patch addresses may be adjusted using
the value
in generic_io_base. This patch makes it possible to set
generic_io_base and
have pci without reading and writing all over the place.

Signed-off-by: Magnus Damm <[email protected]>
Acked-by: Katsuya MATSUBARA <[email protected]>
Signed-off-by: Paul Mundt <[email protected]>

:040000 040000 17a9f8181301e3a082d8a1a2fdef9b13ff1185e4
87e4a2e912be56b0d12e8a92db9489d6615c31f7 M arch


I'll now try reverting this and seeing what happens....


Adrian

2008-02-16 20:00:25

by Adrian McMenamin

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast


On Sat, 2008-02-16 at 19:48 +0000, Adrian McMenamin wrote:
> On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> > Will seek to bisect this, but I have just updated my sources to the
> > latest git and it is not booting at all on the Dreamcast.
> >

> adrian@bossclass:~/gdrom-dev$ git bisect good
> e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
> commit e036eaa681a17f71b64f6d9040fe605555623919
> Author: Magnus Damm <[email protected]>
> Date: Thu Feb 14 13:52:43 2008 +0900
>

Reverting this commit *will* let my Dreamcast boot - can it be rolled
back pending further testing for a patch please?

Adrian

2008-02-17 19:41:49

by Kristoffer Ericson

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast

On Sat, 16 Feb 2008 18:38:00 +0000
Adrian McMenamin <[email protected]> wrote:

> Will seek to bisect this, but I have just updated my sources to the
> latest git and it is not booting at all on the Dreamcast.
>
> With early printk on, I get nothing more than this before an instant
> reboot:

I haven't tested anything after 2.6.24 vanilla which works fine. A bisect sounds like a good idea since you
got pretty much zero clues.

>
> [ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd
> (adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43
> GMT 2008
> [ 0.000000] console [sercon0] enabled
> [ 0.000000] Booting machvec: Sega Dreamcast
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-02-17 19:42:26

by Kristoffer Ericson

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast

On Sat, 16 Feb 2008 19:59:48 +0000
Adrian McMenamin <[email protected]> wrote:

>
> On Sat, 2008-02-16 at 19:48 +0000, Adrian McMenamin wrote:
> > On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> > > Will seek to bisect this, but I have just updated my sources to the
> > > latest git and it is not booting at all on the Dreamcast.
> > >
>
> > adrian@bossclass:~/gdrom-dev$ git bisect good
> > e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
> > commit e036eaa681a17f71b64f6d9040fe605555623919
> > Author: Magnus Damm <[email protected]>
> > Date: Thu Feb 14 13:52:43 2008 +0900
> >
>
> Reverting this commit *will* let my Dreamcast boot - can it be rolled
> back pending further testing for a patch please?

Since you know the cause I'm sure Magnus will have some ideas about why it broke, so just hold on for him to reply.

>
> Adrian
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-02-17 19:55:37

by Kristoffer Ericson

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast

On Sat, 16 Feb 2008 19:59:48 +0000
Adrian McMenamin <[email protected]> wrote:

>
> On Sat, 2008-02-16 at 19:48 +0000, Adrian McMenamin wrote:
> > On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> > > Will seek to bisect this, but I have just updated my sources to the
> > > latest git and it is not booting at all on the Dreamcast.
> > >
>
> > adrian@bossclass:~/gdrom-dev$ git bisect good
> > e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
> > commit e036eaa681a17f71b64f6d9040fe605555623919
> > Author: Magnus Damm <[email protected]>
> > Date: Thu Feb 14 13:52:43 2008 +0900
> >
>
> Reverting this commit *will* let my Dreamcast boot - can it be rolled
> back pending further testing for a patch please?
>

Just had a look at the patch. If that patch made your dreamcast not boot then you had somekind of
io_base that was used in in/out. Perhaps its better to adjust your PORT defines than work around the issue?

> Adrian
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-02-18 08:57:19

by Magnus Damm

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast

Hi Adrian,

[fixed up Matsubara-sans address]

On Feb 17, 2008 4:48 AM, Adrian McMenamin
<[email protected]> wrote:
> On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> > Will seek to bisect this, but I have just updated my sources to the
> > latest git and it is not booting at all on the Dreamcast.
> >
> > With early printk on, I get nothing more than this before an instant
> > reboot:
> >
> > [ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd
> > (adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43
> > GMT 2008
> > [ 0.000000] console [sercon0] enabled
> > [ 0.000000] Booting machvec: Sega Dreamcast
>
>
> adrian@bossclass:~/gdrom-dev$ git bisect good
> e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
> commit e036eaa681a17f71b64f6d9040fe605555623919
> Author: Magnus Damm <[email protected]>
> Date: Thu Feb 14 13:52:43 2008 +0900
>
> sh: use ctrl_in/out for on chip pci access
>
> This patch makes sure ctrl_inN/outN are used instead of inN/outN for
> on chip
> pci registers. Without this patch addresses may be adjusted using
> the value
> in generic_io_base. This patch makes it possible to set
> generic_io_base and
> have pci without reading and writing all over the place.
>
> Signed-off-by: Magnus Damm <[email protected]>
> Acked-by: Katsuya MATSUBARA <[email protected]>
> Signed-off-by: Paul Mundt <[email protected]>
>
> :040000 040000 17a9f8181301e3a082d8a1a2fdef9b13ff1185e4
> 87e4a2e912be56b0d12e8a92db9489d6615c31f7 M arch

Thanks for tracking this down and sorry for breaking the dreamcast pci driver.

Most code for the dreamcast currently do direct register access using
ctrl_inN/outN or readN/writeN. Only a few places use inN/outN and
depend on the value of generic_io_base. Doing inN/outN is ok (but
outdated, use ioreadN/iowriteN instead) in a portable pci/isa driver,
but it doesn't make sense for any dreamcast specific code to rely on
generic_io_base. For the dreamcast we already know the address at
compile time so doing adjustment during runtime is just unnecessary
overhead.

It is of course possible to revert the dreamcast-specific bits of the
commit you pointed out, but I think the change for the dreamcast makes
sense since it makes the code both faster and more uniform.

However, at this point it is broken. Sorry about that. I just looked
through all upstream dreamcast-specific code I could find and irq.c is
now the only file that does inN/outN. I've attached a patch that makes
the irq code independent of generic_io_base. There is also another
patch attached that adjusts the addresses of the pci register.
Together they should solve the problem you are seeing. Please try them
on top of 2.6.25-rc2.

With these patches io ports count from 0 -> 8k-1 instead of being a
pointer. We currently rely on generic_io_base logic but that will be
changed in the future.

Please let me know the results. Thank you.

/ magnus


Attachments:
(No filename) (2.91 kB)
linux-2.6.25-rc2-sh-dreamcast-irq-20080218.patch (2.21 kB)
linux-2.6.25-rc2-sh-dreamcast-pci-20080218b.patch (1.63 kB)
Download all attachments

2008-02-18 20:13:08

by Adrian McMenamin

[permalink] [raw]
Subject: Re: Current git very broken on the Dreamcast


On Mon, 2008-02-18 at 17:57 +0900, Magnus Damm wrote:
> Hi Adrian,
>
> [fixed up Matsubara-sans address]
>
> On Feb 17, 2008 4:48 AM, Adrian McMenamin
> <[email protected]> wrote:
> > On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote:
> > > Will seek to bisect this, but I have just updated my sources to the
> > > latest git and it is not booting at all on the Dreamcast.
> > >
> > > With early printk on, I get nothing more than this before an instant
> > > reboot:
> > >
> > > [ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd
> > > (adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43
> > > GMT 2008
> > > [ 0.000000] console [sercon0] enabled
> > > [ 0.000000] Booting machvec: Sega Dreamcast
> >
> >
> > adrian@bossclass:~/gdrom-dev$ git bisect good
> > e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit
> > commit e036eaa681a17f71b64f6d9040fe605555623919
> > Author: Magnus Damm <[email protected]>
> > Date: Thu Feb 14 13:52:43 2008 +0900
> >
> > sh: use ctrl_in/out for on chip pci access
> >
> > This patch makes sure ctrl_inN/outN are used instead of inN/outN for
> > on chip
> > pci registers. Without this patch addresses may be adjusted using
> > the value
> > in generic_io_base. This patch makes it possible to set
> > generic_io_base and
> > have pci without reading and writing all over the place.
> >
> > Signed-off-by: Magnus Damm <[email protected]>
> > Acked-by: Katsuya MATSUBARA <[email protected]>
> > Signed-off-by: Paul Mundt <[email protected]>
> >
> > :040000 040000 17a9f8181301e3a082d8a1a2fdef9b13ff1185e4
> > 87e4a2e912be56b0d12e8a92db9489d6615c31f7 M arch
>
> Thanks for tracking this down and sorry for breaking the dreamcast pci driver.
>
> Most code for the dreamcast currently do direct register access using
> ctrl_inN/outN or readN/writeN. Only a few places use inN/outN and
> depend on the value of generic_io_base. Doing inN/outN is ok (but
> outdated, use ioreadN/iowriteN instead) in a portable pci/isa driver,
> but it doesn't make sense for any dreamcast specific code to rely on
> generic_io_base. For the dreamcast we already know the address at
> compile time so doing adjustment during runtime is just unnecessary
> overhead.
>
> It is of course possible to revert the dreamcast-specific bits of the
> commit you pointed out, but I think the change for the dreamcast makes
> sense since it makes the code both faster and more uniform.
>
> However, at this point it is broken. Sorry about that. I just looked
> through all upstream dreamcast-specific code I could find and irq.c is
> now the only file that does inN/outN. I've attached a patch that makes
> the irq code independent of generic_io_base. There is also another
> patch attached that adjusts the addresses of the pci register.
> Together they should solve the problem you are seeing. Please try them
> on top of 2.6.25-rc2.
>
> With these patches io ports count from 0 -> 8k-1 instead of being a
> pointer. We currently rely on generic_io_base logic but that will be
> changed in the future.
>
Magnus,

This fixed the original problem but re-introduced the problem I had
before with not having a a working nic - so it's stole broken atm:

[ 2.220263] NET: Registered protocol family 17
[ 2.224976] RPC: Registered udp transport module.
[ 2.228064] RPC: Registered tcp transport module.
[ 2.740995] IP-Config: Failed to open eth0
[ 2.744076] IP-Config: No network devices available.
[ 2.748232] Looking up port of RPC 100003/2 on 192.168.61.50