2008-02-19 00:45:19

by Jan Altenberg

Subject: [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message

Hi all,

commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which
prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This
breaks the RNDIS initialization (especially / only Windoze machines
dislike this behavior...).

Signed-off-by: Benedikt Spranger <[email protected]>
Signed-off-by: Jan Altenberg <[email protected]>

---
drivers/usb/gadget/ether.c | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6.24/drivers/usb/gadget/ether.c
===================================================================
--- linux-2.6.24.orig/drivers/usb/gadget/ether.c
+++ linux-2.6.24/drivers/usb/gadget/ether.c
@@ -1568,6 +1568,7 @@ done_set_intf:
memcpy(req->buf, buf, n);
req->complete = rndis_response_complete;
rndis_free_response(dev->rndis_config, buf);
+ value = n;
}
/* else stalls ... spec says to avoid that */
}

2008-02-19 02:15:11

by David Brownell

Subject: Re: [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message

On Monday 18 February 2008, Jan Altenberg wrote:
> Hi all,
>
> commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which
> prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This
> breaks the RNDIS initialization (especially / only Windoze machines
> dislike this behavior...).
>
> Signed-off-by: Benedikt Spranger <[email protected]>
> Signed-off-by: Jan Altenberg <[email protected]>

Acked-by: David Brownell <[email protected]>


> ---
> drivers/usb/gadget/ether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6.24/drivers/usb/gadget/ether.c
> ===================================================================
> --- linux-2.6.24.orig/drivers/usb/gadget/ether.c
> +++ linux-2.6.24/drivers/usb/gadget/ether.c
> @@ -1568,6 +1568,7 @@ done_set_intf:
> memcpy(req->buf, buf, n);
> req->complete = rndis_response_complete;
> rndis_free_response(dev->rndis_config, buf);
> + value = n;
> }
> /* else stalls ... spec says to avoid that */
> }
>
>