2008-02-22 20:02:50

by Adrian Bunk

Subject: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static

This patch makes the needlessly global blkif_getgeo() static.

Signed-off-by: Adrian Bunk <[email protected]>

---
6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 9c6f3f9..ae7ee16 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
schedule_work(&info->work);
}

-int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
+static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
{
/* We don't have real geometry info, but let's at least return
values consistent with the size of the device */

2008-02-22 20:45:37

by Ian Campbell

Subject: Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static

On Fri, 2008-02-22 at 21:58 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global blkif_getgeo() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ian Campbell <[email protected]>

>
> ---
> 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9c6f3f9..ae7ee16 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
> schedule_work(&info->work);
> }
>
> -int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> +static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> {
> /* We don't have real geometry info, but let's at least return
> values consistent with the size of the device */
>
>
--
Ian Campbell

WHERE CAN THE MATTER BE
Oh, dear, where can the matter be
When it's converted to energy?
There is a slight loss of parity.
Johnny's so long at the fair.