2008-02-23 23:06:24

by Priit Laes

[permalink] [raw]
Subject: [PATCH] x86: fix build on non-C locales.



Attachments:
x86-fix-build-on-non-C-locales.patch (868.00 B)

2008-02-24 08:08:12

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] x86: fix build on non-C locales.


* Priit Laes <[email protected]> wrote:

> x86: fix build on some non-C locales[1].
>
> For some locales regex range [a-zA-Z] does not work as it is supposed
> to so we have to specify LANG=C to make it work as intended.

thanks, applied.

Ingo

2008-02-24 09:03:36

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] x86: fix build on non-C locales.

Hi Prit.

Could we just use [[:alnum:]] and drop the setting of LC_ALL?

Sam

2008-02-24 16:35:48

by Priit Laes

[permalink] [raw]
Subject: Re: [PATCH] x86: fix build on non-C locales.


Ühel kenal päeval, P, 2008-02-24 kell 10:03, kirjutas Sam Ravnborg:
> Hi Prit.
>
> Could we just use [[:alnum:]] and drop the setting of LC_ALL?
Yes, it works. Reverted the previous patch and did this:

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index f385a4b..b8bd0c4 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -48,7 +48,7 @@ obj-$(VDSO64-y) += vdso-syms.lds
# Match symbols in the DSO that look like VDSO*; produce a file of
constants.
#
sed-vdsosym := -e 's/^00*/0/' \
- -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
+ -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'
quiet_cmd_vdsosym = VDSOSYM $@
cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort >
$@

2008-02-24 16:50:04

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] x86: fix build on non-C locales.


* Priit Laes <[email protected]> wrote:

> sed-vdsosym := -e 's/^00*/0/' \
> - -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
> + -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'

thanks, i picked up this one instead of the first version.

Ingo