2008-03-13 06:56:58

by Zhang Wei

Subject: [PATCH] fsldma: Add a completed cookie updated action in DMA finish interrupt.

The patch 'fsldma: do not cleanup descriptors in hardirq context'
(commit 222ccf9ab838a1ca7163969fabd2cddc10403fb5) removed descriptors
cleanup function to tasklet but the completed cookie do not updated.
Thus, the DMA controller will get lots of duplicated transfer
interrupts. Just make a completed cookie update in interrupt handler.
And keep other cleanup jobs in tasklet function.

Signed-off-by: Zhang Wei <[email protected]>
---
drivers/dma/fsldma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 5428f81..7c957c3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -539,7 +539,6 @@ static void fsl_chan_ld_cleanup(struct fsl_dma_chan *fsl_chan)

spin_lock_irqsave(&fsl_chan->desc_lock, flags);

- fsl_dma_update_completed_cookie(fsl_chan);
dev_dbg(fsl_chan->dev, "chan completed_cookie = %d\n",
fsl_chan->completed_cookie);
list_for_each_entry_safe(desc, _desc, &fsl_chan->ld_queue, node) {
@@ -710,6 +709,7 @@ static irqreturn_t fsl_dma_chan_do_interrupt(int irq, void *data)
dev_dbg(fsl_chan->dev, "event: clndar %p, nlndar %p\n",
(void *)get_cdar(fsl_chan), (void *)get_ndar(fsl_chan));
stat &= ~FSL_DMA_SR_EOSI;
+ fsl_dma_update_completed_cookie(fsl_chan);
}

/* If it current transfer is the end-of-transfer,
--
1.5.4

2008-03-13 09:31:17

by Sebastian Siewior

Subject: Re: [PATCH] fsldma: Add a completed cookie updated action in DMA finish interrupt.

* Zhang Wei | 2008-03-13 14:54:20 [+0800]:

>The patch 'fsldma: do not cleanup descriptors in hardirq context'
>(commit 222ccf9ab838a1ca7163969fabd2cddc10403fb5) removed descriptors
>cleanup function to tasklet but the completed cookie do not updated.
>Thus, the DMA controller will get lots of duplicated transfer
>interrupts. Just make a completed cookie update in interrupt handler.
>And keep other cleanup jobs in tasklet function.
>
>Signed-off-by: Zhang Wei <[email protected]>
Tested-by: Sebastian Siewior <[email protected]>