2019-03-25 02:52:21

by Yue Haibing

Subject: [PATCH v3] dccp: Fix memleak in __feat_register_sp

From: YueHaibing <[email protected]>

If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.

Reported-by: Hulk Robot <[email protected]>
Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
Signed-off-by: YueHaibing <[email protected]>
---
v3: fix compile issue, sorry for this again
v2: kfree 'val --> 'fval'
---
net/dccp/feat.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index f227f00..db87d9f 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
return -ENOMEM;

- return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
+ if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
+ kfree(fval.sp.vec);
+ return -ENOMEM;
+ }
+
+ return 0;
}

/**
--
2.7.4

2019-03-25 03:45:42

by David Miller

Subject: Re: [PATCH v3] dccp: Fix memleak in __feat_register_sp

I said DO NOT submit any networking patches for at least 2 days, and yet
you still posted a followup to this?

Please don't. I'm ignoring all of your submissions for at least 2 days.

2019-03-27 14:57:00

by Mukesh Ojha

Subject: Re: [PATCH v3] dccp: Fix memleak in __feat_register_sp

On 3/25/2019 8:11 AM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> If dccp_feat_push_change fails, we forget free the mem
> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
> Signed-off-by: YueHaibing <[email protected]>


Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh

> ---
> v3: fix compile issue, sorry for this again
> v2: kfree 'val --> 'fval'
> ---
> net/dccp/feat.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/dccp/feat.c b/net/dccp/feat.c
> index f227f00..db87d9f 100644
> --- a/net/dccp/feat.c
> +++ b/net/dccp/feat.c
> @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
> if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
> return -ENOMEM;
>
> - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
> + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
> + kfree(fval.sp.vec);
> + return -ENOMEM;
> + }
> +
> + return 0;
> }
>
> /**