2008-06-09 10:47:07

by Pierre Ossman

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Fri, 30 May 2008 13:49:59 +0200
Nicolas Ferre <[email protected]> wrote:

> Hi Pierre,
>
> Following your announce of future removal of the MMC multiwrite switch
> and the contributions of several people of the AT91 community, here is a
> patches series :
> Those patches should enhance transfer of data and setup a sane base for
> a working SDIO support.
>

I have no big concerns about the patches. There were some comments from
other people though. Do you want to have a look at those first?

Rgds
Pierre


Attachments:
signature.asc (197.00 B)

2008-06-10 09:55:27

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

Pierre Ossman :
> On Fri, 30 May 2008 13:49:59 +0200
> Nicolas Ferre <[email protected]> wrote:
>
>> Hi Pierre,
>>
>> Following your announce of future removal of the MMC multiwrite switch
>> and the contributions of several people of the AT91 community, here is a
>> patches series :
>> Those patches should enhance transfer of data and setup a sane base for
>> a working SDIO support.
>>
>
> I have no big concerns about the patches.

Ok, good !

> There were some comments from
> other people though. Do you want to have a look at those first?

Russell King highlights that patch #4 is not well inserted in the series
: it have to be after #5 (after correcting bytes_xfered update).

If you want I can reorder them... or you manage to do it.

I will take into account Marc's comment and new Ville patch series in
another round ;-)

Btw, you can also add the "manage cmd error and data error
independently" patch I have just sent.

Kind regards,
--
Nicolas Ferre

2008-06-14 16:29:20

by Pierre Ossman

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Tue, 10 Jun 2008 11:54:41 +0200
Nicolas Ferre <[email protected]> wrote:

>
> Russell King highlights that patch #4 is not well inserted in the series
> : it have to be after #5 (after correcting bytes_xfered update).
>
> If you want I can reorder them... or you manage to do it.
>
> I will take into account Marc's comment and new Ville patch series in
> another round ;-)

Will you redo this series, or are you planning further patches? (i.e.
should I merge this set or wait for an update?)


Attachments:
signature.asc (197.00 B)

2008-06-18 10:05:26

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

Pierre Ossman :
> On Tue, 10 Jun 2008 11:54:41 +0200
> Nicolas Ferre <[email protected]> wrote:
>
>> Russell King highlights that patch #4 is not well inserted in the series
>> : it have to be after #5 (after correcting bytes_xfered update).
>>
>> If you want I can reorder them... or you manage to do it.
>>
>> I will take into account Marc's comment and new Ville patch series in
>> another round ;-)
>
> Will you redo this series, or are you planning further patches? (i.e.
> should I merge this set or wait for an update?)

You can merge this patch series (7 patches)

You can also merge
http://lists.arm.linux.org.uk/lurker/message/20080610.092729.beef9e64.en.html
"at91_mci: manage cmd error and data error independently" (1 patch)

And 3 patches from Ville Syrj?l? that I have just signed:
http://lists.arm.linux.org.uk/lurker/message/20080614.172720.dd0e776e.en.html
"at91_mci: AT91SAM9260/9263 12 byte write erratum (v2)"


http://lists.arm.linux.org.uk/lurker/message/20080609.190644.3f64ff91.en.html
"at91_mci: Cover more AT91RM9200 and AT91SAM9261 errata."


http://lists.arm.linux.org.uk/lurker/message/20080609.190645.2998e511.en.html
"at91_mci: Fix byte mode transitions."

=> 11 patches.

Thanks a lot, regards,
--
Nicolas Ferre

2008-06-18 11:01:43

by Erik Mouw

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, Jun 18, 2008 at 12:04:49PM +0200, Nicolas Ferre wrote:

[...]

Could you all drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list in
this thread? The address is invalid because it has no domain part and
hence causes quite some bounces on the list because some strict email
checkers reject invalid addresses in the Cc list.

I'm trying to figure out what went wrong, but in the mean time please
drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list.


Erik
[linux-arm-kernel-owner #2]

--
Erik Mouw -- [email protected]


Attachments:
(No filename) (529.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments

2008-06-18 11:16:37

by Erik Mouw

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, Jun 18, 2008 at 12:47:23PM +0200, Erik Mouw wrote:
> On Wed, Jun 18, 2008 at 12:04:49PM +0200, Nicolas Ferre wrote:
>
> [...]
>
> Could you all drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list in
> this thread? The address is invalid because it has no domain part and
> hence causes quite some bounces on the list because some strict email
> checkers reject invalid addresses in the Cc list.
>
> I'm trying to figure out what went wrong, but in the mean time please
> drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list.

Found it, Mailman is to blame. On the linux-kernel mailing list, the
address shows up ok: "=?ISO-8859-1?Q?Hans-J=FCrgen_?=
=?ISO-8859-1?Q?Koch?= <[email protected]>".

What probably happens: Mailman tries to check if the addresses in the
To and CC fields are subscribed to the list (linux-arm-kernel). If that
is the case and the subscriber enabled "prevent doubles", it won't send
that particular subscriber the message. Of course, this should have
been implemented by a simple strncmp() on the To and CC fields, but I
guess Mailman first breaks up the To and CC fields, then does the
"prevent double" check, and then reassembles the To and CC fields.
Apparently there is an error in the break up or reassembly. Now how to
fix this without breaking Mailman alltogether...

In the mean time, could you just use Hans-J?rgen's address
([email protected]>) and not his name in the CC field?


Erik
[linux-arm-kernel-owner #2]
(thanks to David Woodhouse for helping to debug the problem)

--
Erik Mouw -- [email protected]


Attachments:
(No filename) (1.52 kB)
signature.asc (189.00 B)
Digital signature
Download all attachments

2008-06-18 11:43:47

by Hans J. Koch

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, Jun 18, 2008 at 01:16:07PM +0200, Erik Mouw wrote:
> On Wed, Jun 18, 2008 at 12:47:23PM +0200, Erik Mouw wrote:
> > On Wed, Jun 18, 2008 at 12:04:49PM +0200, Nicolas Ferre wrote:
> >
> > [...]
> >
> > Could you all drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list in
> > this thread? The address is invalid because it has no domain part and
> > hence causes quite some bounces on the list because some strict email
> > checkers reject invalid addresses in the Cc list.
> >
> > I'm trying to figure out what went wrong, but in the mean time please
> > drop =?ISO-8859-1?Q?Hans-J=FCrgen_?= from the Cc list.
>
> Found it, Mailman is to blame. On the linux-kernel mailing list, the
> address shows up ok: "=?ISO-8859-1?Q?Hans-J=FCrgen_?=
> =?ISO-8859-1?Q?Koch?= <[email protected]>".
>
> What probably happens: Mailman tries to check if the addresses in the
> To and CC fields are subscribed to the list (linux-arm-kernel). If that
> is the case and the subscriber enabled "prevent doubles", it won't send
> that particular subscriber the message. Of course, this should have
> been implemented by a simple strncmp() on the To and CC fields, but I
> guess Mailman first breaks up the To and CC fields, then does the
> "prevent double" check, and then reassembles the To and CC fields.
> Apparently there is an error in the break up or reassembly. Now how to
> fix this without breaking Mailman alltogether...
>
> In the mean time, could you just use Hans-J?rgen's address
> ([email protected]>) and not his name in the CC field?

I avoided the German umlaut in my name by using the abbreviation "Hans
J. Koch" on mailing lists. Unfortunately, I still have one mail client
that uses the full name. I'll fix that to avoid similar trouble.

On the other hand, I used that for quite a while now, and didn't have
problems. It shouldn't be too difficult to have these programs use UTF-8
(or any other charset) properly these days.

Thanks,
Hans

>
>
> Erik
> [linux-arm-kernel-owner #2]
> (thanks to David Woodhouse for helping to debug the problem)
>
> --
> Erik Mouw -- [email protected]

2008-06-18 11:48:16

by David Woodhouse

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, 2008-06-18 at 13:40 +0200, Hans J. Koch wrote:
>
> I avoided the German umlaut in my name by using the abbreviation "Hans
> J. Koch" on mailing lists. Unfortunately, I still have one mail client
> that uses the full name. I'll fix that to avoid similar trouble.
>
> On the other hand, I used that for quite a while now, and didn't have
> problems. It shouldn't be too difficult to have these programs use
> UTF-8 (or any other charset) properly these days.

I'm not convinced it's a problem with rfc2047 handling; I think it's
simpler brain-damage than that on mailman's part. It's to do with line
wrapping, iirc -- if an address spans two lines, like: David Woodhouse
<[email protected]>, then mailman will brokenly insert a comma where
the line break happened -- or something like that.

--
dwmw2

2008-06-18 13:36:00

by Erik Mouw

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, Jun 18, 2008 at 12:47:50PM +0100, David Woodhouse wrote:
> On Wed, 2008-06-18 at 13:40 +0200, Hans J. Koch wrote:
> >
> > I avoided the German umlaut in my name by using the abbreviation "Hans
> > J. Koch" on mailing lists. Unfortunately, I still have one mail client
> > that uses the full name. I'll fix that to avoid similar trouble.
> >
> > On the other hand, I used that for quite a while now, and didn't have
> > problems. It shouldn't be too difficult to have these programs use
> > UTF-8 (or any other charset) properly these days.
>
> I'm not convinced it's a problem with rfc2047 handling; I think it's
> simpler brain-damage than that on mailman's part. It's to do with line
> wrapping, iirc -- if an address spans two lines, like: David Woodhouse
> <[email protected]>, then mailman will brokenly insert a comma where
> the line break happened -- or something like that.

It's a bit more complicated cause Mailman gets this right:

ARM Linux Mailing List
<[email protected]>,

It also gets RFC2407 right:

=?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= <[email protected]>

I guess it's a combination that goes wrong:

=?ISO-8859-1?Q?Hans-J=FCrgen_?= =?ISO-8859-1?Q?Koch?=
<[email protected]>

Maybe if J?rgen's mailer made that something like:

=?ISO-8859-1Q!Hans-J=FCrgen_Koch?=

Mailman wouldn't have crippled the address?

Oh well, rmk isn't available for a few days so I can't really debug the
Mailman version on lists.arm.linux.org.uk :(


Erik

--
Erik Mouw -- [email protected]


Attachments:
(No filename) (1.50 kB)
signature.asc (189.00 B)
Digital signature
Download all attachments

2008-06-18 13:37:28

by David Woodhouse

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, 2008-06-18 at 15:35 +0200, Erik Mouw wrote:
> Oh well, rmk isn't available for a few days so I can't really debug the
> Mailman version on lists.arm.linux.org.uk :(

I can set up a test list for you to screw around with if you like.

--
dwmw2

2008-06-18 15:17:45

by Erik Mouw

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, Jun 18, 2008 at 02:37:05PM +0100, David Woodhouse wrote:
> On Wed, 2008-06-18 at 15:35 +0200, Erik Mouw wrote:
> > Oh well, rmk isn't available for a few days so I can't really debug the
> > Mailman version on lists.arm.linux.org.uk :(
>
> I can set up a test list for you to screw around with if you like.

No need for that, I can install Mailman on my laptop. Thanks for the
offer, though.


Erik

--
Erik Mouw -- [email protected]


Attachments:
(No filename) (444.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments

2008-06-20 16:30:40

by Pierre Ossman

[permalink] [raw]
Subject: Re: [PATCH 0/7] mmc: at91_mci: rework to allow better transfer

On Wed, 18 Jun 2008 12:04:49 +0200
Nicolas Ferre <[email protected]> wrote:

>
> You can merge this patch series (7 patches)
>

Everything merged up. It'll be hitting kernel.org soon.

Rgds
--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Use end-to-end encryption where
possible.


Attachments:
signature.asc (197.00 B)