2008-07-03 21:31:23

by Harvey Harrison

Subject: [PATCH] crypto: rmd160.c rmd256.c rmd320.c sparse annotations

Similar to the rmd128.c annotations, significantly cuts down on the
noise.

Signed-off-by: Harvey Harrison <[email protected]>
---
crypto/rmd160.c | 8 ++++----
crypto/rmd256.c | 8 ++++----
crypto/rmd320.c | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/crypto/rmd160.c b/crypto/rmd160.c
index e9fd5f6..f001ec7 100644
--- a/crypto/rmd160.c
+++ b/crypto/rmd160.c
@@ -26,7 +26,7 @@
struct rmd160_ctx {
u64 byte_count;
u32 state[5];
- u32 buffer[16];
+ __le32 buffer[16];
};

#define K1 RMD_K1
@@ -52,7 +52,7 @@ struct rmd160_ctx {
(c) = rol32((c), 10); \
}

-static void rmd160_transform(u32 *state, u32 const *in)
+static void rmd160_transform(u32 *state, const __le32 *in)
{
u32 aa, bb, cc, dd, ee, aaa, bbb, ccc, ddd, eee;

@@ -313,8 +313,8 @@ static void rmd160_final(struct crypto_tfm *tfm, u8 *out)
{
struct rmd160_ctx *rctx = crypto_tfm_ctx(tfm);
u32 i, index, padlen;
- u64 bits;
- u32 *dst = (u32 *)out;
+ __le64 bits;
+ __le32 *dst = (__le32 *)out;
static const u8 padding[64] = { 0x80, };

bits = cpu_to_le64(rctx->byte_count << 3);
diff --git a/crypto/rmd256.c b/crypto/rmd256.c
index b088526..e3de5b4 100644
--- a/crypto/rmd256.c
+++ b/crypto/rmd256.c
@@ -26,7 +26,7 @@
struct rmd256_ctx {
u64 byte_count;
u32 state[8];
- u32 buffer[16];
+ __le32 buffer[16];
};

#define K1 RMD_K1
@@ -48,7 +48,7 @@ struct rmd256_ctx {
(a) = rol32((a), (s)); \
}

-static void rmd256_transform(u32 *state, u32 const *in)
+static void rmd256_transform(u32 *state, const __le32 *in)
{
u32 aa, bb, cc, dd, aaa, bbb, ccc, ddd, tmp;

@@ -288,8 +288,8 @@ static void rmd256_final(struct crypto_tfm *tfm, u8 *out)
{
struct rmd256_ctx *rctx = crypto_tfm_ctx(tfm);
u32 i, index, padlen;
- u64 bits;
- u32 *dst = (u32 *)out;
+ __le64 bits;
+ __le32 *dst = (__le32 *)out;
static const u8 padding[64] = { 0x80, };

bits = cpu_to_le64(rctx->byte_count << 3);
diff --git a/crypto/rmd320.c b/crypto/rmd320.c
index dba03ec..b143d66 100644
--- a/crypto/rmd320.c
+++ b/crypto/rmd320.c
@@ -26,7 +26,7 @@
struct rmd320_ctx {
u64 byte_count;
u32 state[10];
- u32 buffer[16];
+ __le32 buffer[16];
};

#define K1 RMD_K1
@@ -52,7 +52,7 @@ struct rmd320_ctx {
(c) = rol32((c), 10); \
}

-static void rmd320_transform(u32 *state, u32 const *in)
+static void rmd320_transform(u32 *state, const __le32 *in)
{
u32 aa, bb, cc, dd, ee, aaa, bbb, ccc, ddd, eee, tmp;

@@ -337,8 +337,8 @@ static void rmd320_final(struct crypto_tfm *tfm, u8 *out)
{
struct rmd320_ctx *rctx = crypto_tfm_ctx(tfm);
u32 i, index, padlen;
- u64 bits;
- u32 *dst = (u32 *)out;
+ __le64 bits;
+ __le32 *dst = (__le32 *)out;
static const u8 padding[64] = { 0x80, };

bits = cpu_to_le64(rctx->byte_count << 3);
--
1.5.6.1.281.g1087e

2008-07-04 11:50:06

by Herbert Xu

Subject: Re: [PATCH] crypto: rmd160.c rmd256.c rmd320.c sparse annotations

On Thu, Jul 03, 2008 at 02:30:42PM -0700, Harvey Harrison wrote:
> Similar to the rmd128.c annotations, significantly cuts down on the
> noise.
>
> Signed-off-by: Harvey Harrison <[email protected]>

All applied.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt