2008-07-11 11:09:03

by tip-bot for Robert Richter

Subject: [PATCH] x86/pci: Removing pci-y in Makefile

Cc: Sam Ravnborg <[email protected]>
Signed-off-by: Robert Richter <[email protected]>
---
arch/x86/pci/Makefile | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
index e515e8d..28451f4 100644
--- a/arch/x86/pci/Makefile
+++ b/arch/x86/pci/Makefile
@@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
obj-$(CONFIG_PCI_DIRECT) += direct.o
obj-$(CONFIG_PCI_OLPC) += olpc.o

-pci-y := fixup.o
-pci-$(CONFIG_ACPI) += acpi.o
-pci-y += legacy.o irq.o
+obj-y += fixup.o
+obj-$(CONFIG_ACPI) += acpi.o
+obj-y += legacy.o irq.o

-pci-$(CONFIG_X86_VISWS) += visws.o
+obj-$(CONFIG_X86_VISWS) += visws.o

-pci-$(CONFIG_X86_NUMAQ) += numa.o
+obj-$(CONFIG_X86_NUMAQ) += numa.o

-obj-y += $(pci-y) common.o early.o
+obj-y += common.o early.o
obj-y += amd_bus.o
--
1.5.5.4

2008-07-11 12:03:25

by Sam Ravnborg

Subject: Re: [PATCH] x86/pci: Removing pci-y in Makefile

On Fri, Jul 11, 2008 at 12:13:59PM +0200, Robert Richter wrote:
> Cc: Sam Ravnborg <[email protected]>
> Signed-off-by: Robert Richter <[email protected]>
> ---
> arch/x86/pci/Makefile | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> index e515e8d..28451f4 100644
> --- a/arch/x86/pci/Makefile
> +++ b/arch/x86/pci/Makefile
> @@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
> obj-$(CONFIG_PCI_DIRECT) += direct.o
> obj-$(CONFIG_PCI_OLPC) += olpc.o
>
> -pci-y := fixup.o
> -pci-$(CONFIG_ACPI) += acpi.o
> -pci-y += legacy.o irq.o
> +obj-y += fixup.o

Hi Robert.
Now I see the full patch I understood your comment.
I had missed that there was assignments above fixup.o

Acked-by: Sam Ravnborg <[email protected]>

Sam

2008-07-11 12:26:37

by tip-bot for Robert Richter

Subject: Re: [PATCH] x86/pci: Removing pci-y in Makefile

On 11.07.08 14:04:05, Sam Ravnborg wrote:
> On Fri, Jul 11, 2008 at 12:13:59PM +0200, Robert Richter wrote:
> > Cc: Sam Ravnborg <[email protected]>
> > Signed-off-by: Robert Richter <[email protected]>
> > ---
> > arch/x86/pci/Makefile | 12 ++++++------
> > 1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> > index e515e8d..28451f4 100644
> > --- a/arch/x86/pci/Makefile
> > +++ b/arch/x86/pci/Makefile
> > @@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
> > obj-$(CONFIG_PCI_DIRECT) += direct.o
> > obj-$(CONFIG_PCI_OLPC) += olpc.o
> >
> > -pci-y := fixup.o
> > -pci-$(CONFIG_ACPI) += acpi.o
> > -pci-y += legacy.o irq.o
> > +obj-y += fixup.o
>
> Hi Robert.
> Now I see the full patch I understood your comment.
> I had missed that there was assignments above fixup.o

Yes, it was not the first entry.

-Robert

>
> Acked-by: Sam Ravnborg <[email protected]>
>
> Sam
>
>

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]