Subject: [PATCH] iwlwifi: fix iwl-led compile issue when CONFIG_IWLWIFI_DEBUG is not set

Fix compile error when CONFIG_IWLWIFI_DEBUG not defined.

Signed-off-by: Fernando Luis Vazquez Cao <[email protected]>
---

--- linux-2.6.27-rc1/drivers/net/wireless/iwlwifi/iwl-led.c 2008-07-29 13:51:26.000000000 +0900
+++ linux-2.6.27-rc1-iocontext/drivers/net/wireless/iwlwifi/iwl-led.c 2008-07-29 14:47:13.000000000 +0900
@@ -194,9 +194,10 @@ static void iwl_led_brightness_set(struc
if (test_bit(STATUS_EXIT_PENDING, &priv->status))
return;

-
+#ifdef CONFIG_IWLWIFI_DEBUG
IWL_DEBUG_LED("Led type = %s brightness = %d\n",
led_type_str[led->type], brightness);
+#endif /* CONFIG_IWLWIFI_DEBUG */
switch (brightness) {
case LED_FULL:
if (led->type == IWL_LED_TRG_ASSOC)


2008-07-29 08:42:17

by Tomas Winkler

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: fix iwl-led compile issue when CONFIG_IWLWIFI_DEBUG is not set

On Tue, Jul 29, 2008 at 8:58 AM, Fernando Luis V?zquez Cao
<[email protected]> wrote:
> Fix compile error when CONFIG_IWLWIFI_DEBUG not defined.
>
> Signed-off-by: Fernando Luis Vazquez Cao <[email protected]>
> ---
>
> --- linux-2.6.27-rc1/drivers/net/wireless/iwlwifi/iwl-led.c 2008-07-29 13:51:26.000000000 +0900
> +++ linux-2.6.27-rc1-iocontext/drivers/net/wireless/iwlwifi/iwl-led.c 2008-07-29 14:47:13.000000000 +0900
> @@ -194,9 +194,10 @@ static void iwl_led_brightness_set(struc
> if (test_bit(STATUS_EXIT_PENDING, &priv->status))
> return;
>
> -
> +#ifdef CONFIG_IWLWIFI_DEBUG
> IWL_DEBUG_LED("Led type = %s brightness = %d\n",
> led_type_str[led->type], brightness);
> +#endif /* CONFIG_IWLWIFI_DEBUG */
> switch (brightness) {
> case LED_FULL:
> if (led->type == IWL_LED_TRG_ASSOC)

NACK
Fixes were already sent out find them on the milling list
Tomas