2008-08-02 15:51:01

by Gustavo F. Padovan

Subject: [PATCH 0/1] delta patch to arch/x86/kernel/traps_64.c

Ingo,

This patch fixes coding style to previous patch to traps_64.c
(4df9e510a9fda29aca71d8acac853b98aa6884d1 on tip/x86/cleanups).

2008-08-02 15:50:49

by Gustavo F. Padovan

Subject: [PATCH 1/1] x86: coding style fixes to arch/x86/kernel/traps_64.c

Fix coding style of traps_64.c with improvements suggested by Ingo.

Signed-off-by: Gustavo F. Padovan <[email protected]>
---
arch/x86/kernel/traps_64.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/traps_64.c b/arch/x86/kernel/traps_64.c
index fe36d96..5df5d2e 100644
--- a/arch/x86/kernel/traps_64.c
+++ b/arch/x86/kernel/traps_64.c
@@ -84,8 +84,8 @@ static inline void preempt_conditional_cli(struct pt_regs *regs)

void printk_address(unsigned long address, int reliable)
{
- printk(" [<%016lx>] %s%pS\n", address, reliable ?
- "" : "? ", (void *) address);
+ printk(" [<%016lx>] %s%pS\n",
+ address, reliable ? "" : "? ", (void *) address);
}

static unsigned long *in_exception_stack(unsigned cpu, unsigned long stack,
@@ -98,8 +98,8 @@ static unsigned long *in_exception_stack(unsigned cpu, unsigned long stack,
[STACKFAULT_STACK - 1] = "#SS",
[MCE_STACK - 1] = "#MC",
#if DEBUG_STKSZ > EXCEPTION_STKSZ
- [N_EXCEPTION_STACKS ... N_EXCEPTION_STACKS + DEBUG_STKSZ /
- EXCEPTION_STKSZ - 2] = "#DB[?]"
+ [N_EXCEPTION_STACKS ...
+ N_EXCEPTION_STACKS + DEBUG_STKSZ / EXCEPTION_STKSZ - 2] = "#DB[?]"
#endif
};
unsigned k;
@@ -363,8 +363,10 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
unsigned long *irqstack =
(unsigned long *) (cpu_pda(cpu)->irqstackptr - IRQSTACKSIZE);

- /* debugging aid: "show_stack(NULL, NULL);" prints the
- back trace for this cpu. */
+ /*
+ * debugging aid: "show_stack(NULL, NULL);" prints the
+ * back trace for this cpu.
+ */

if (sp == NULL) {
if (task)
--
1.5.4.5

2008-08-15 16:12:25

by Ingo Molnar

Subject: Re: [PATCH 1/1] x86: coding style fixes to arch/x86/kernel/traps_64.c

* Gustavo F. Padovan <[email protected]> wrote:

> Fix coding style of traps_64.c with improvements suggested by Ingo.
>
> Signed-off-by: Gustavo F. Padovan <[email protected]>

applied to tip/x86/cleanups - thanks Gustavo!

Ingo