2008-08-09 22:57:15

by Harvey Harrison

Subject: [PATCH] cred: add static, remove extern on function definitions

kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition
kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <[email protected]>
---
Introduced between next-20080729 and next-20080808

kernel/cred.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index f89c5e5..d91cb06 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -69,7 +69,7 @@ static void put_tgcred_rcu(struct rcu_head *rcu)
/*
* Release a set of thread group credentials.
*/
-void put_tgcred(struct thread_group_cred *tgcred)
+static void put_tgcred(struct thread_group_cred *tgcred)
{
if (atomic_dec_and_test(&tgcred->usage))
call_rcu(&tgcred->rcu, put_tgcred_rcu);
@@ -457,7 +457,7 @@ EXPORT_SYMBOL(override_creds);
* Revert a temporary set of override subjective credentials to an old set,
* discarding the override set.
*/
-extern void revert_creds(const struct cred *old)
+void revert_creds(const struct cred *old)
{
const struct cred *override = current->cred;

--
1.6.0.rc1.278.g9c632

2008-08-10 11:01:41

by David Howells

Subject: Re: [PATCH] cred: add static, remove extern on function definitions

Harvey Harrison <[email protected]> wrote:

> kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition
> kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <[email protected]>

Acked-by: David Howells <[email protected]>

2008-08-10 22:46:31

by James Morris

Subject: Re: [PATCH] cred: add static, remove extern on function definitions

On Sun, 10 Aug 2008, David Howells wrote:

> Harvey Harrison <[email protected]> wrote:
>
> > kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition
> > kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?
> >
> > Signed-off-by: Harvey Harrison <[email protected]>
>
> Acked-by: David Howells <[email protected]>

Applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds


--
James Morris
<[email protected]>