2008-08-19 21:16:31

by Thomas Meyer

Subject: Fwd: 2.6.26.3: ACPI: Fix thermal shutdowns

Hi.

This one should go in 2.6.26.3, too:

I didn't see it in Greg's list:

ACPI: Fix thermal shutdowns

Do not use unsigned int if there is test for negative number...

See drivers/acpi/processor_perflib.c
static unsigned int ignore_ppc = -1;
...
if (event == CPUFREQ_START && ignore_ppc <= 0) {
ignore_ppc = 0;
...


http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f497bcc695fb828da023d74ad3c966b1e58ad21

Greets
thomas

2008-08-19 21:25:24

by Rafael J. Wysocki

Subject: Re: Fwd: 2.6.26.3: ACPI: Fix thermal shutdowns

On Tuesday, 19 of August 2008, Thomas Meyer wrote:
>
> Hi.
>
> This one should go in 2.6.26.3, too:
>
> I didn't see it in Greg's list:

Why haven't you sent a CC to Greg, then? :-)

> ACPI: Fix thermal shutdowns
>
> Do not use unsigned int if there is test for negative number...
>
> See drivers/acpi/processor_perflib.c
> static unsigned int ignore_ppc = -1;
> ...
> if (event == CPUFREQ_START && ignore_ppc <= 0) {
> ignore_ppc = 0;
> ...
>
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f497bcc695fb828da023d74ad3c966b1e58ad21