2008-10-29 01:41:34

by Harvey Harrison

Subject: [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem

Signed-off-by: Harvey Harrison <[email protected]>
---
Arjan, when you added this helper I think you omitted the iomem
annotation.

include/linux/pci.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index c75b82b..feb4657 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1136,7 +1136,7 @@ static inline void pci_mmcfg_late_init(void) { }
#endif

#ifdef CONFIG_HAS_IOMEM
-static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
+static inline void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
{
/*
* Make sure the BAR is actually a memory resource, not an IO resource
--
1.6.0.3.756.gb776d

2008-10-29 03:44:04

by Arjan van de Ven

Subject: Re: [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem

On Tue, 28 Oct 2008 18:41:17 -0700
Harvey Harrison <[email protected]> wrote:

> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> Arjan, when you added this helper I think you omitted the iomem
> annotation.

fair enough

Acked-by: Arjan van de Ven <[email protected]>