2008-10-30 21:49:03

by Johann Felix Soden

Subject: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module

From: Johann Felix Soden <[email protected]>

The 'ret' variable is assigned, but not used in the return statement. Fix this.

Signed-off-by: Johann Felix Soden <[email protected]>
CC: Jason Baron <[email protected]>
---
lib/dynamic_printk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d83660f..d0fd0e4 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
nr_entries--;
out:
up(&debug_list_mutex);
- return 0;
+ return ret;
}
EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);

--
1.5.6.5

2008-10-31 20:41:21

by Jason Baron

Subject: Re: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module

On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
> From: Johann Felix Soden <[email protected]>
>
> The 'ret' variable is assigned, but not used in the return statement. Fix this.
>
> Signed-off-by: Johann Felix Soden <[email protected]>
> CC: Jason Baron <[email protected]>
> ---
> lib/dynamic_printk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
> index d83660f..d0fd0e4 100644
> --- a/lib/dynamic_printk.c
> +++ b/lib/dynamic_printk.c
> @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
> nr_entries--;
> out:
> up(&debug_list_mutex);
> - return 0;
> + return ret;
> }
> EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
>

looks good to me.

Acked-by: Jason Baron <[email protected]>

thanks,

-Jason