2008-11-07 20:24:59

by Matt LaPlante

[permalink] [raw]
Subject: [PATCH] Change default for STRICT_DEVMEM

The recommendation for STRICT_DEVMEM is to select Y,
however the option currently defaults to N. Have the option
default to Y since it is recommended.

---
arch/x86/Kconfig.debug | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 2a3dfbd..a03597c 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -7,6 +7,7 @@ source "lib/Kconfig.debug"

config STRICT_DEVMEM
bool "Filter access to /dev/mem"
+ default y
help
If this option is disabled, you allow userspace (root) access to all
of memory, including kernel and userspace memory. Accidental
--
1.5.6.3


2008-11-07 22:04:49

by Alan

[permalink] [raw]
Subject: Re: [PATCH] Change default for STRICT_DEVMEM

On Fri, 7 Nov 2008 14:18:36 -0600
Matt LaPlante <[email protected]> wrote:

> The recommendation for STRICT_DEVMEM is to select Y,
> however the option currently defaults to N. Have the option
> default to Y since it is recommended.

The recommendation is extremely dubious as it breaks a lot of back
compatibility.

2008-11-07 23:20:50

by Matt LaPlante

[permalink] [raw]
Subject: Re: [PATCH] Change default for STRICT_DEVMEM

On Fri, 7 Nov 2008 22:00:38 +0000
Alan Cox <[email protected]> wrote:

> On Fri, 7 Nov 2008 14:18:36 -0600
> Matt LaPlante <[email protected]> wrote:
>
> > The recommendation for STRICT_DEVMEM is to select Y,
> > however the option currently defaults to N. Have the option
> > default to Y since it is recommended.
>
> The recommendation is extremely dubious as it breaks a lot of back
> compatibility.
>
Revert the default and toggle the recommendation then?

--
Matt LaPlante <[email protected]>

2008-11-08 04:30:59

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [PATCH] Change default for STRICT_DEVMEM

On Fri, 7 Nov 2008 22:00:38 +0000
Alan Cox <[email protected]> wrote:

> On Fri, 7 Nov 2008 14:18:36 -0600
> Matt LaPlante <[email protected]> wrote:
>
> > The recommendation for STRICT_DEVMEM is to select Y,
> > however the option currently defaults to N. Have the option
> > default to Y since it is recommended.
>
> The recommendation is extremely dubious as it breaks a lot of back
> compatibility.
>

the default recommendatiom is a typo. It used to be an "other way
around" config option, and it got flipped into a "positive" option
rather than a tripple negative, but the help text didn't get fixed
properly.



--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org

2008-11-08 11:42:51

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] Change default for STRICT_DEVMEM


* Matt LaPlante <[email protected]> wrote:

> The recommendation for STRICT_DEVMEM is to select Y,
> however the option currently defaults to N. Have the option
> default to Y since it is recommended.
>
> ---
> arch/x86/Kconfig.debug | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

no. This is a special case: due to compatibility we default to N, but
still we recommend people/distros to enable it. Eventually we can
switch around the default in the future, but not yet.

Ingo