2008-11-10 05:37:24

by Harvey Harrison

[permalink] [raw]
Subject: [PATCH 3/3] lib: proportions.c trivial sparse lock annotation

Suppresses sparse warning:
lib/proportions.c:159:16: warning: context imbalance in 'prop_get_global': wrong count at exit
lib/proportions.c:159:16: context 'RCU': wanted 0, got 1
lib/proportions.c:164:2: warning: context imbalance in 'prop_put_global': unexpected unlock
lib/proportions.c:164:2: context 'RCU': wanted 0, got -1

Signed-off-by: Harvey Harrison <[email protected]>
---
lib/proportions.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/proportions.c b/lib/proportions.c
index 4f387a6..3fda810 100644
--- a/lib/proportions.c
+++ b/lib/proportions.c
@@ -147,6 +147,7 @@ out:
* this is used to track the active references.
*/
static struct prop_global *prop_get_global(struct prop_descriptor *pd)
+__acquires(RCU)
{
int index;

@@ -160,6 +161,7 @@ static struct prop_global *prop_get_global(struct prop_descriptor *pd)
}

static void prop_put_global(struct prop_descriptor *pd, struct prop_global *pg)
+__releases(RCU)
{
rcu_read_unlock();
}
--
1.6.0.3.866.gc189b