2008-11-10 09:39:26

by Kamezawa Hiroyuki

Subject: [BUGFIX][PATCH] memcg: memory hotplug fix

This is a bug fix reported against 2.6.28-rc3 from Badari.
Badari, could you give me Ack or Tested-by ?

Thanks,
-Kame
==
start pfn calculation of page_cgroup's memory hotplug notifier chain
is wrong.

Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>


mm/page_cgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: mmotm-2.6.28-Oct30/mm/page_cgroup.c
===================================================================
--- mmotm-2.6.28-Oct30.orig/mm/page_cgroup.c
+++ mmotm-2.6.28-Oct30/mm/page_cgroup.c
@@ -165,7 +165,7 @@ int online_page_cgroup(unsigned long sta
unsigned long start, end, pfn;
int fail = 0;

- start = start_pfn & (PAGES_PER_SECTION - 1);
+ start = start_pfn & ~(PAGES_PER_SECTION - 1);
end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);

for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) {
@@ -188,7 +188,7 @@ int offline_page_cgroup(unsigned long st
{
unsigned long start, end, pfn;

- start = start_pfn & (PAGES_PER_SECTION - 1);
+ start = start_pfn & ~(PAGES_PER_SECTION - 1);
end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);

for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)

2008-11-10 15:51:37

by Badari Pulavarty

Subject: Re: [BUGFIX][PATCH] memcg: memory hotplug fix

On Mon, 2008-11-10 at 18:38 +0900, KAMEZAWA Hiroyuki wrote:
> This is a bug fix reported against 2.6.28-rc3 from Badari.
> Badari, could you give me Ack or Tested-by ?
>
> Thanks,
> -Kame
> ==
> start pfn calculation of page_cgroup's memory hotplug notifier chain
> is wrong.
>
> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>

Tested-by: Badari Pulavarty <[email protected]>