2008-11-13 10:22:11

by Petr Tesařík

Subject: [PATCH] remove an unnecessary field in struct tcp_skb_cb

The urg_ptr field is not used anywhere and is merely confusing.

Signed-off-by: Petr Tesarik <[email protected]>

--
include/net/tcp.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 438014d..8f26b28 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -590,7 +590,6 @@ struct tcp_skb_cb {
#define TCPCB_EVER_RETRANS 0x80 /* Ever retransmitted frame */
#define TCPCB_RETRANS (TCPCB_SACKED_RETRANS|TCPCB_EVER_RETRANS)

- __u16 urg_ptr; /* Valid w/URG flags is set. */
__u32 ack_seq; /* Sequence number ACK'd */
};

2008-11-13 18:11:16

by Saikiran Madugula

Subject: Re: [PATCH] remove an unnecessary field in struct tcp_skb_cb

Petr Tesarik wrote:
> The urg_ptr field is not used anywhere and is merely confusing.
>
grep -r "urg_ptr" on my linux tree says otherwise.

2008-11-13 19:58:16

by Andi Kleen

Subject: Re: [PATCH] remove an unnecessary field in struct tcp_skb_cb

Saikiran Madugula <[email protected]> writes:

> Petr Tesarik wrote:
>> The urg_ptr field is not used anywhere and is merely confusing.
>>
> grep -r "urg_ptr" on my linux tree says otherwise.

I think you're confusing it with tcphdr's field of the same name.
Petr's patch is correct as far as I can see.

-Andi
--
[email protected]

2008-11-14 06:55:53

by David Miller

Subject: Re: [PATCH] remove an unnecessary field in struct tcp_skb_cb

From: Andi Kleen <[email protected]>
Date: Thu, 13 Nov 2008 20:57:53 +0100

> Saikiran Madugula <[email protected]> writes:
>
> > Petr Tesarik wrote:
> >> The urg_ptr field is not used anywhere and is merely confusing.
> >>
> > grep -r "urg_ptr" on my linux tree says otherwise.
>
> I think you're confusing it with tcphdr's field of the same name.
> Petr's patch is correct as far as I can see.

Right, patch applied, thanks everyone.