2008-11-17 15:11:35

by Denis V. Lunev

Subject: [PATCH] ipc: do not goto to the next line

Signed-off-by: Denis V. Lunev <[email protected]>
---
ipc/sem.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/ipc/sem.c b/ipc/sem.c
index 0821224..b91d455 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
if (timeout && jiffies_left == 0)
error = -EAGAIN;
list_del(&queue.list);
- goto out_unlock_free;

out_unlock_free:
sem_unlock(sma);
--
1.5.6.4

2008-11-17 15:31:46

by Cong Wang

Subject: Re: [PATCH] ipc: do not goto to the next line

On Mon, Nov 17, 2008 at 06:10:52PM +0300, Denis V. Lunev wrote:
>Signed-off-by: Denis V. Lunev <[email protected]>
>---
> ipc/sem.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/ipc/sem.c b/ipc/sem.c
>index 0821224..b91d455 100644
>--- a/ipc/sem.c
>+++ b/ipc/sem.c
>@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
> if (timeout && jiffies_left == 0)
> error = -EAGAIN;
> list_del(&queue.list);
>- goto out_unlock_free;
>
> out_unlock_free:
> sem_unlock(sma);

Aha, this goto is obviously useless. :)

If you need,
Reviewed-by: WANG Cong <[email protected]>


--
"Sometimes the only way to stay sane is to go a little crazy."