2008-12-15 17:44:06

by Jaswinder Singh Rajput

Subject: [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used

Signed-off-by: Jaswinder Singh <[email protected]>

Included asm/arch_hooks.h for init_ISA_irqs
---
arch/x86/kernel/irqinit_64.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
index b33d02f..d1f9663 100644
--- a/arch/x86/kernel/irqinit_64.c
+++ b/arch/x86/kernel/irqinit_64.c
@@ -21,6 +21,7 @@
#include <asm/delay.h>
#include <asm/desc.h>
#include <asm/apic.h>
+#include <asm/arch_hooks.h>
#include <asm/i8259.h>

/*
--
1.5.5.1

2008-12-15 19:53:31

by Yinghai Lu

Subject: Re: [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used

On Mon, Dec 15, 2008 at 9:42 AM, Jaswinder Singh
<[email protected]> wrote:
> Signed-off-by: Jaswinder Singh <[email protected]>
>
> Included asm/arch_hooks.h for init_ISA_irqs
> ---
> arch/x86/kernel/irqinit_64.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
> index b33d02f..d1f9663 100644
> --- a/arch/x86/kernel/irqinit_64.c
> +++ b/arch/x86/kernel/irqinit_64.c
> @@ -21,6 +21,7 @@
> #include <asm/delay.h>
> #include <asm/desc.h>
> #include <asm/apic.h>
> +#include <asm/arch_hooks.h>
> #include <asm/i8259.h>


not needed.

could change that to static for 64bit.

YH

2008-12-16 03:51:21

by Jaswinder Singh Rajput

Subject: Re: [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used

On Mon, 2008-12-15 at 11:53 -0800, Yinghai Lu wrote:

>
> not needed.
>
> could change that to static for 64bit.
>

Thanks for your suggestion.

I also CC '[PATCH] x86: irqinit_64.c init_ISA_irqs should be static' to
you :-)

Thank you,

Jaswinder Singh.