2008-12-19 17:05:44

by Jaswinder Singh Rajput

Subject: [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static

Impact: cleanup, avoid sparse warnings, reduce kernel size a bit

Fixes these sparse warnings:
arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static?
arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh <[email protected]>
---
arch/x86/kernel/cpu/common.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index cd7437c..e57a725 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -866,7 +866,7 @@ EXPORT_SYMBOL(_cpu_pda);

struct desc_ptr idt_descr = { 256 * 16 - 1, (unsigned long) idt_table };

-char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;
+static char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;

void __cpuinit pda_init(int cpu)
{
@@ -907,8 +907,8 @@ void __cpuinit pda_init(int cpu)
}
}

-char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
- DEBUG_STKSZ] __page_aligned_bss;
+static char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
+ DEBUG_STKSZ] __page_aligned_bss;

extern asmlinkage void ignore_sysret(void);

--
1.5.5.1

2008-12-19 22:16:39

by Ingo Molnar

Subject: Re: [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static

* Jaswinder Singh <[email protected]> wrote:

> Impact: cleanup, avoid sparse warnings, reduce kernel size a bit
>
> Fixes these sparse warnings:
> arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static?
> arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh <[email protected]>
> ---
> arch/x86/kernel/cpu/common.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

applied to tip/x86/cleanups, thanks!

Ingo