2009-01-01 08:22:20

by Ben Nizette

[permalink] [raw]
Subject: [PATCH] avr32: Remove DMATEST from defconfigs


In the defconfigs for ATNGW100 and ATSTK100[236] the DMA Test driver is
compiled as a module. This means systems built with *_defconfig +
CONFIG_MODULES=n are unusable as the 3 dma test channels monopolise the
CPU.

I 'spose Haavard uses this module a lot but IMO it isn't really
something needed on all eval boards by default.

Signed-off-by: Ben Nizette <[email protected]>

---

Please don't hate me if this patch is munged, holiday mailer :-)

arch/avr32/configs/atngw100_defconfig | 2 +-
arch/avr32/configs/atstk1002_defconfig | 2 +-
arch/avr32/configs/atstk1003_defconfig | 2 +-
arch/avr32/configs/atstk1006_defconfig | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/avr32/configs/atngw100_defconfig b/arch/avr32/configs/atngw100_defconfig
index 5415209..164e281 100644
--- a/arch/avr32/configs/atngw100_defconfig
+++ b/arch/avr32/configs/atngw100_defconfig
@@ -892,7 +892,7 @@ CONFIG_DMA_ENGINE=y
# DMA Clients
#
# CONFIG_NET_DMA is not set
-CONFIG_DMATEST=m
+# CONFIG_DMATEST is not set
# CONFIG_UIO is not set

#
diff --git a/arch/avr32/configs/atstk1002_defconfig b/arch/avr32/configs/atstk1002_defconfig
index 69fce6b..c9dc648 100644
--- a/arch/avr32/configs/atstk1002_defconfig
+++ b/arch/avr32/configs/atstk1002_defconfig
@@ -964,7 +964,7 @@ CONFIG_DMA_ENGINE=y
# DMA Clients
#
# CONFIG_NET_DMA is not set
-CONFIG_DMATEST=m
+# CONFIG_DMATEST is not set
# CONFIG_UIO is not set

#
diff --git a/arch/avr32/configs/atstk1003_defconfig b/arch/avr32/configs/atstk1003_defconfig
index 5477ed3..29ea132 100644
--- a/arch/avr32/configs/atstk1003_defconfig
+++ b/arch/avr32/configs/atstk1003_defconfig
@@ -882,7 +882,7 @@ CONFIG_DMA_ENGINE=y
# DMA Clients
#
# CONFIG_NET_DMA is not set
-CONFIG_DMATEST=m
+# CONFIG_DMATEST is not set
# CONFIG_UIO is not set

#
diff --git a/arch/avr32/configs/atstk1006_defconfig b/arch/avr32/configs/atstk1006_defconfig
index 6c45a3b..361c31c 100644
--- a/arch/avr32/configs/atstk1006_defconfig
+++ b/arch/avr32/configs/atstk1006_defconfig
@@ -1014,7 +1014,7 @@ CONFIG_DMA_ENGINE=y
# DMA Clients
#
# CONFIG_NET_DMA is not set
-CONFIG_DMATEST=m
+# CONFIG_DMATEST is not set
# CONFIG_UIO is not set
# CONFIG_STAGING is not set
CONFIG_STAGING_EXCLUDE_BUILD=y


2009-01-06 13:46:17

by Haavard Skinnemoen

[permalink] [raw]
Subject: Re: [PATCH] avr32: Remove DMATEST from defconfigs

Ben Nizette wrote:
> In the defconfigs for ATNGW100 and ATSTK100[236] the DMA Test driver is
> compiled as a module. This means systems built with *_defconfig +
> CONFIG_MODULES=n are unusable as the 3 dma test channels monopolise the
> CPU.
>
> I 'spose Haavard uses this module a lot but IMO it isn't really
> something needed on all eval boards by default.
>
> Signed-off-by: Ben Nizette <[email protected]>
>
> ---
>
> Please don't hate me if this patch is munged, holiday mailer :-)

It applied just fine, thanks!

Haavard