2009-01-13 06:39:25

by Jaswinder Singh Rajput

Subject: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace

Impact: fix make headers_check warning:

usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/coda_psdev.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
index 07ae8f8..c620958 100644
--- a/include/linux/coda_psdev.h
+++ b/include/linux/coda_psdev.h
@@ -87,6 +87,8 @@ struct upc_req {
* Statistics
*/

+#ifdef __KERNEL__
extern struct venus_comm coda_comms[];
+#endif /* __KERNEL__ */

#endif
--
1.5.6.6

2009-01-13 07:22:42

by Harvey Harrison

Subject: Re: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace

On Tue, 2009-01-13 at 12:06 +0530, Jaswinder Singh Rajput wrote:
> Impact: fix make headers_check warning:
>
> usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---
> include/linux/coda_psdev.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
> index 07ae8f8..c620958 100644
> --- a/include/linux/coda_psdev.h
> +++ b/include/linux/coda_psdev.h
> @@ -87,6 +87,8 @@ struct upc_req {
> * Statistics
> */
>
> +#ifdef __KERNEL__
> extern struct venus_comm coda_comms[];
> +#endif /* __KERNEL__ */

As this only gets used in code/inode.c, coda/psdev.c it would be nice if
a code-internal header could be found that could hold this.

This is only here due to the one use outside of psdev.c in inode.c

Harvey